From owner-cvs-src@FreeBSD.ORG Wed Feb 23 06:45:19 2005 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0B21916A4CE; Wed, 23 Feb 2005 06:45:19 +0000 (GMT) Received: from critter.freebsd.dk (f170.freebsd.dk [212.242.86.170]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4CBB143D1F; Wed, 23 Feb 2005 06:45:18 +0000 (GMT) (envelope-from phk@critter.freebsd.dk) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.13.1/8.13.1) with ESMTP id j1N6jEH0058264; Wed, 23 Feb 2005 07:45:14 +0100 (CET) (envelope-from phk@critter.freebsd.dk) To: Jeff Roberson From: "Poul-Henning Kamp" In-Reply-To: Your message of "Wed, 23 Feb 2005 01:41:01 EST." <20050223014018.Y52537@mail.chesapeake.net> Date: Wed, 23 Feb 2005 07:45:14 +0100 Message-ID: <58263.1109141114@critter.freebsd.dk> Sender: phk@critter.freebsd.dk cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/sys vnode.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Feb 2005 06:45:19 -0000 In message <20050223014018.Y52537@mail.chesapeake.net>, Jeff Roberson writes: >On Wed, 23 Feb 2005, Poul-Henning Kamp wrote: > >> In message <20050222180223.V52537@mail.chesapeake.net>, Jeff Roberson writes: >> >On Tue, 22 Feb 2005, Poul-Henning Kamp wrote: >> > >> >> phk 2005-02-22 18:49:03 UTC >> >> >> >> FreeBSD src repository >> >> >> >> Modified files: >> >> sys/sys vnode.h >> >> Log: >> >> Group the fields in struct vnode by their function and stick comments >> >> there to tell what the function is. >> > >> >They were sorted according to the lock that they used. I still prefer >> >that, prehaps with sorting by use secondly. >> >> That doesn't make sense. The comment says which lock they use so people >> can still see that, but appearantly people had big trouble seeing what >> fields belonged where. > >It was so that we minimize cache hits, and cause a minimum number of >synchronized writes when we release the mutex. It still doesn't make sense Jeff, they're still mostly ordered by lock if you look carefully. A little shuffling inside the groups will make it even more so. And I want to see benchmarks before you claim any performance degradation because I ram benchmarks and was not even within one tenth of the standard deviation. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence.