Date: Mon, 07 Jun 2004 22:07:42 +0200 From: Stefan Ehmann <shoesoft@gmx.net> To: Robert Watson <rwatson@freebsd.org> Cc: current@freebsd.org Subject: Re: esd leaking file descriptors Message-ID: <1086638862.724.2.camel@taxman> In-Reply-To: <Pine.NEB.3.96L.1040607153907.88690C-100000@fledge.watson.org> References: <Pine.NEB.3.96L.1040607153907.88690C-100000@fledge.watson.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 2004-06-07 at 21:40, Robert Watson wrote: > On Mon, 7 Jun 2004, Brian Feldman wrote: > > > > I just tried a kernel from June, 1st: esd doesn't leak any file > > > descriptors. So it's definitely a CURRENT problem. > > > > > > I couldn't spot anything suspicous using ktrace (That is no notable > > > difference compared to the other machine). > > > > > > Here are two excerpts from kdump output that basically repeat all the > > > time: > > > > I see a lot of accept(2) there... I think it's a good possibility Robert > > accidentally broke accept[1]()'s error cleanup. It seems that the file > > is dropped but the fd is left sitting around in a half-allocated state. > > Many of those 'goto done;'s should be 'goto noconnection;'s, I believe. > > That's what I was wondering -- it looks like the 'goto done's following > falloc()'s failure check should be "goto noconnection". Here's a patch > that cleans that up, but may not be perfect. I get a panic when trying to access esd now: panic: free address has not been allocated
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1086638862.724.2.camel>