From owner-svn-src-all@FreeBSD.ORG Tue Feb 28 22:11:13 2012 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 225B1106566B; Tue, 28 Feb 2012 22:11:13 +0000 (UTC) (envelope-from giovanni.trematerra@gmail.com) Received: from mail-qy0-f182.google.com (mail-qy0-f182.google.com [209.85.216.182]) by mx1.freebsd.org (Postfix) with ESMTP id AFEF58FC14; Tue, 28 Feb 2012 22:11:12 +0000 (UTC) Received: by qcsg15 with SMTP id g15so1826933qcs.13 for ; Tue, 28 Feb 2012 14:11:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; bh=wP/NNCAWuMjx9qhUmBvUXhBSZ+9hu9w6fVegR4W4K1k=; b=C5gEOVtUWQPUbg0TCzFrjxa6q6frfPOjqFq0BAroeeCXRgfOJrw5xXCA1ypAnNGKiM PkKO+yZBRw1G5+iPEVIIrt3KfBHiNUR+QKcLKqfTO9IAu/N6uP378aab6XF70otKjaQE mMQU1vL/tsUzb2G/xWy5EER9C3jJm1M3BgjEc= MIME-Version: 1.0 Received: by 10.229.102.101 with SMTP id f37mr6966639qco.37.1330467072127; Tue, 28 Feb 2012 14:11:12 -0800 (PST) Received: by 10.229.86.200 with HTTP; Tue, 28 Feb 2012 14:11:12 -0800 (PST) In-Reply-To: <201202282145.q1SLjLpO093657@svn.freebsd.org> References: <201202282145.q1SLjLpO093657@svn.freebsd.org> Date: Tue, 28 Feb 2012 23:11:12 +0100 Message-ID: From: Giovanni Trematerra To: Dimitry Andric Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r232271 - head/sys/kern X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Feb 2012 22:11:13 -0000 On Tue, Feb 28, 2012 at 10:45 PM, Dimitry Andric wrote: > Author: dim > Date: Tue Feb 28 21:45:21 2012 > New Revision: 232271 > URL: http://svn.freebsd.org/changeset/base/232271 > > Log: > =A0Change definition of pipe_chmod() from K&R to C99, to avoid the > =A0following clang warning: > > =A0sys/kern/sys_pipe.c:1556:10: error: promoted type 'int' of K&R functio= n parameter is not compatible with the parameter type 'mode_t' > =A0 =A0 =A0 =A0(aka 'unsigned short') declared in a previous prototype [-= Werror] > =A0 =A0 =A0 =A0 =A0mode_t mode; > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 ^ > =A0sys/kern/sys_pipe.c:155:19: note: previous declaration is here > =A0static fo_chmod_t =A0 =A0 =A0 pipe_chmod; > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0^ > > Modified: > =A0head/sys/kern/sys_pipe.c > > Modified: head/sys/kern/sys_pipe.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/sys/kern/sys_pipe.c =A0 =A0Tue Feb 28 21:43:29 2012 =A0 =A0 =A0 = =A0(r232270) > +++ head/sys/kern/sys_pipe.c =A0 =A0Tue Feb 28 21:45:21 2012 =A0 =A0 =A0 = =A0(r232271) > @@ -1551,11 +1551,7 @@ pipe_close(fp, td) > =A0} > > =A0static int > -pipe_chmod(fp, mode, active_cred, td) > - =A0 =A0 =A0 struct file *fp; > - =A0 =A0 =A0 mode_t mode; > - =A0 =A0 =A0 struct ucred *active_cred; > - =A0 =A0 =A0 struct thread *td; > +pipe_chmod(struct file *fp, mode_t mode, struct ucred *active_cred, stru= ct thread *td) > =A0{ > =A0 =A0 =A0 =A0struct pipe *cpipe; > =A0 =A0 =A0 =A0int error; Thank you. It introduces a style(9) violation, though. I think it should be in this way pipe_chmod(struct file *fp, mode_t mode, struct ucred *active_cred, struct thread *td) Anyway that's not a problem I can take care of this and other style violati= ons during next weeks. -- Gianni