Date: Fri, 08 Oct 1999 21:18:58 +0200 From: Poul-Henning Kamp <phk@critter.freebsd.dk> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/vm vm_swap.c Message-ID: <4944.939410338@critter.freebsd.dk> In-Reply-To: Your message of "Fri, 08 Oct 1999 12:10:19 PDT." <199910081910.MAA18645@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <199910081910.MAA18645@freefall.freebsd.org>, Poul-Henning Kamp writ es: >phk 1999/10/08 12:10:19 PDT > > Modified files: > sys/vm vm_swap.c > Log: > Fix a panic(8) implementation: > hexdump -C < /dev/drum > by simply refusing to do I/O from userland. > a panic. I'm not sure we even need /dev/drum anymore, it seems > to have been broken for a long time thi My vi caved in on me, here is the ungarbeled version: Fix a panic(8) implementation: hexdump -C < /dev/drum by simply refusing to do I/O from userland. Substitute noread and nowrite for physread and physwrite, and make two dev_t's, one with minor zero which can be opened from userland but not sent throug strategt, and one with minor one which is used for swapvp. It is not clear to me what purpose userland access to the "drum" device serve these days. I can see that libkvm opens the drum, but considering that this bug have existed for around to 9 months, I gather that it never actually does any reads or writes to /dev/drum. Unless somebody else beats me to it or explains why we need to keep it, /dev/drum is now scheduled for demolition. -- Poul-Henning Kamp FreeBSD coreteam member phk@FreeBSD.ORG "Real hackers run -current on their laptop." FreeBSD -- It will take a long time before progress goes too far! To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4944.939410338>