Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 10 Nov 2018 23:27:53 +0100
From:      Antoine Brodin <antoine@freebsd.org>
To:        Gerald Pfeifer <gerald@pfeifer.com>
Cc:        Baptiste Daroussin <bapt@freebsd.org>, FreeBSD Ports Management Team <portmgr@freebsd.org>,  ports-committers <ports-committers@freebsd.org>, svn-ports-all@freebsd.org,  svn-ports-head@freebsd.org
Subject:   Re: svn commit: r484628 - in head: . Mk Templates accessibility/speech-dispatcher archivers/fastjar archivers/gcpio archivers/gtar archivers/gzip archivers/lzip archivers/lzlib archivers/plzip archiver...
Message-ID:  <CAALwa8=dW2H8R0woRT-vwGiC4=NoUwONhSk3jyQp7hQDzQ8uRg@mail.gmail.com>
In-Reply-To: <alpine.LSU.2.21.1811102318500.19949@anthias.pfeifer.com>
References:  <201811101812.wAAICwTS081936@repo.freebsd.org> <alpine.LSU.2.21.1811102318500.19949@anthias.pfeifer.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Nov 10, 2018 at 11:19 PM Gerald Pfeifer <gerald@pfeifer.com> wrote:
>
> On Sat, 10 Nov 2018, Baptiste Daroussin wrote:
> > Author: bapt
> > URL: https://svnweb.freebsd.org/changeset/ports/484628
> >
> > Log:
> >   Install texinfo files (GNU info) into ${PREFIX}/share/info
> :
> >   Other benefit than consistency are less patching: all build tools but
> >   cmake are expecting info files to be under share/info and cmake (patched here)
> >   was having an exception for BSD so the patch makes FreeBSD case less
> >   specific for them
> >
> >   Bump revision of all impacted ports
> >
> >   PR:         232907
> >   exp-run by: antoine
> >   Differential Revision:      https://reviews.freebsd.org/D17816
>
> After this change I am now getting the following for all my lang/gcc*
> ports when subjecting them to my usual testing (which installs into a
> non-standard and fresh/empty prefix):
>
>
> ====> Checking for pkg-plist issues (check-plist)
> ===> Parsing plist
> ===> Checking for items in STAGEDIR missing from pkg-plist
> Error: Orphaned: share/info/gcc7/dir
> ===> Checking for items in pkg-plist which are not in STAGEDIR
> ===> Error: Plist issues found.
> ===> Warning: Test was done with PREFIX != LOCALBASE
> ===> Warning: The port may not be properly installing into PREFIX
> *** Error code 1
>
> Stop.
> make: stopped in /home/gerald/ports/lang/gcc7-devel
>
>
> The patch below addresses this.  Okay to commit?
>
> Gerald @FreeBSD.org
>
>
> Index: Mk/Scripts/check-stagedir.sh
> ===================================================================
> --- Mk/Scripts/check-stagedir.sh        (revision 484633)
> +++ Mk/Scripts/check-stagedir.sh        (working copy)
> @@ -154,7 +154,7 @@
>                 */.svn/*|'@dir '*/.svn) ;;
>                 */.svnignore) ;;
>                 */CVS/*|'@dir '*/CVS) ;;
> -               */info/dir|info/dir|info/*/dir) ;;
> +               */info/dir|info/dir|info/*/dir|share/info/*/dir) ;;
>                 share/fonts/*/fonts.dir) ;;
>                 share/fonts/*/fonts.scale) ;;
>                 share/applications/mimeinfo.cache) ;;

Approved.

Antoine



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAALwa8=dW2H8R0woRT-vwGiC4=NoUwONhSk3jyQp7hQDzQ8uRg>