Date: Sun, 16 Aug 2009 09:22:37 +0400 From: pluknet <pluknet@gmail.com> To: FreeBSD Current <freebsd-current@freebsd.org> Subject: Re: broken regression/acct for several years Message-ID: <a31046fc0908152222k2f7b3fdfwe36fa7e4c84d5645@mail.gmail.com> In-Reply-To: <a31046fc0908152213u5980d00es1e27ef8904b8077d@mail.gmail.com> References: <a31046fc0908152213u5980d00es1e27ef8904b8077d@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
2009/8/16 pluknet <pluknet@gmail.com>: > Hi. > > This commit - kern_acct.c,v1,94 / svn r172023 - broke > regression/acct just before 7.0 was out by inclusion > kernel log() function call that requires <sys/syslog.h> include, > and some magic with kernel/userland side of syslog() since > log() on userland side is =A0not present. > > It could be fixed by changing log() with simple printf() and > adding <sys/limits.h> specially for regression test to [Sorry, wrong button pressed] to fix "LONG_MAX undefined", so it would be like: convert.c: ../../../sys/kern/kern_acct.c - sed -n '/FLOAT_CONVERSION_START/,/FLOAT_CONVERSION_END/p' $? >= $@ + echo "#include <sys/limits.h>" > $@ + sed -n '/FLOAT_CONVERSION_START/,/FLOAT_CONVERSION_END/p' $? >>= $@ or by reverting r172023. Thanks. --=20 wbr, pluknet
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?a31046fc0908152222k2f7b3fdfwe36fa7e4c84d5645>