Date: Fri, 18 Jan 2002 23:19:56 +0600 From: Max Khon <fjoe@iclub.nsu.ru> To: Alexey Dokuchaev <danfe@inet.ssc.nsu.ru> Cc: arch@freebsd.org Subject: Re: request for review Message-ID: <20020118231955.A53559@iclub.nsu.ru> In-Reply-To: <Pine.LNX.4.10.10201182050310.13522-100000@inet.ssc.nsu.ru>; from danfe@inet.ssc.nsu.ru on Fri, Jan 18, 2002 at 09:20:31PM %2B0600 References: <20020115205053.A9241@iclub.nsu.ru> <Pine.LNX.4.10.10201182050310.13522-100000@inet.ssc.nsu.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
hi, there!
On Fri, Jan 18, 2002 at 09:20:31PM +0600, Alexey Dokuchaev wrote:
> And the last thing, I've been looking at the patch, and thought, maybe it
> would be more clear to patch vfs_vnops.c the following way instead:
>
> --- /sys/kern/vfs_vnops.c.orig Fri Jan 18 21:16:33 2002
> +++ /sys/kern/vfs_vnops.c Thu Jan 17 20:26:11 2002
> @@ -530,7 +530,7 @@
> * Default to zero to catch bogus uses of this field.
> */
>
> - if (vap->va_type == VREG) {
> + if (vap->va_type == VREG || vap->va_type == VCHR) {
> sb->st_blksize = vap->va_blocksize;
> } else if (vn_isdisk(vp, NULL)) {
> sb->st_blksize = vp->v_rdev->si_bsize_best;
>
> What do you think?
this will break `vn_isdisk(vp, NULL)' check (it will always return 0)
/fjoe
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-arch" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020118231955.A53559>