Date: Tue, 26 Apr 2011 10:57:15 +0100 From: Gavin Atkinson <gavin@FreeBSD.org> To: "David E. O'Brien" <obrien@FreeBSD.org> Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r221053 - head/usr.bin/rlogin Message-ID: <1303811835.49968.6.camel@buffy.york.ac.uk> In-Reply-To: <201104260409.p3Q49KaJ006272@svn.freebsd.org> References: <201104260409.p3Q49KaJ006272@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 2011-04-26 at 04:09 +0000, David E. O'Brien wrote: > Author: obrien > Date: Tue Apr 26 04:09:20 2011 > New Revision: 221053 > URL: http://svn.freebsd.org/changeset/base/221053 >=20 > Log: > This builds OK using the parent dir's WARNS=3D6. > [built on both AMD64 and i386] As a general rule, just compiling on i386 and amd64 are not sufficient to test WARNS bumps. It's usually sufficient to also crossbuild to a platform like sparc64 which has stricter alignment, but for a full test a "make universe" is best, as this will also catch other issues (for example arm, where char is unsigned). Thanks, Gavin --=20 Gavin Atkinson FreeBSD committer and bugmeister GPG: A093262B (313A A79F 697D 3A5C 216A EDF5 935D EF44 A093 262B)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1303811835.49968.6.camel>