Date: Mon, 26 Mar 2007 18:25:16 +0300 From: Giorgos Keramidas <keramida@freebsd.org> To: Andre Oppermann <andre@freebsd.org> Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/netinet tcp_sack.c Message-ID: <20070326152515.GA1621@kobe.laptop> In-Reply-To: <200703252327.l2PNRR38029221@repoman.freebsd.org> References: <200703252327.l2PNRR38029221@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2007-03-25 23:27, Andre Oppermann <andre@freebsd.org> wrote: > andre 2007-03-25 23:27:27 UTC > > FreeBSD src repository > > Modified files: > sys/netinet tcp_sack.c > Log: > In tcp_sack_doack() remove too tight KASSERT() added in last revision. This > function may be called without any TCP SACK option blocks present. Protect > iteration over SACK option blocks by checking for SACK options present flag > first. > > Bug reported by: wkoszek, keramida, Nicolas Blais > > Revision Changes Path > 1.36 +16 -14 src/sys/netinet/tcp_sack.c Fantastic, thanks! I'm now running a new kernel, compiled from sources which have been updated to "Mon Mar 26 09:10:28 2007 +0000" sources, and no panics have been observed so far with net.inet.tcp.sack.enable=1 :-)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20070326152515.GA1621>