Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 16 Aug 2018 11:18:17 -0500
From:      Kyle Evans <kevans@freebsd.org>
To:        "Rodney W. Grimes" <rgrimes@freebsd.org>
Cc:        src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org,  svn-src-stable@freebsd.org, svn-src-stable-11@freebsd.org,  Warner Losh <imp@freebsd.org>
Subject:   Re: svn commit: r337884 - stable/11/bin/ls
Message-ID:  <CACNAnaF3TqdGUXs4Y1mb%2BhWh1j0_e5UN6LFU8=PhLkuevK=mCQ@mail.gmail.com>
In-Reply-To: <201808160124.w7G1O1mb051118@pdx.rh.CN85.dnsmgr.net>
References:  <201808160118.w7G1IL90006511@repo.freebsd.org> <201808160124.w7G1O1mb051118@pdx.rh.CN85.dnsmgr.net>

next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Aug 15, 2018 at 8:24 PM, Rodney W. Grimes
<freebsd@pdx.rh.cn85.dnsmgr.net> wrote:
>> Author: kevans
>> Date: Thu Aug 16 01:18:20 2018
>> New Revision: 337884
>> URL: https://svnweb.freebsd.org/changeset/base/337884
>>
>> Log:
>>   Revert r337826: MFC of ls(1) COLORTERM honoring
>>
>>   It was not ready, and was much-objected-to.
>
> Thanks, just objected to, not much.
> I think once the --color=foo and the NULL COLORTERM
> fix goes in this should work as expected and not
> cause the issue seen by the user, or if it does
> I can tell them how to get color VIM, but not
> color ls without too much magic.
>

I've opened a review for my --color=foo implementation here:
https://reviews.freebsd.org/D16741

Please take a look when you have time.

Thanks,

Kyle Evans



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CACNAnaF3TqdGUXs4Y1mb%2BhWh1j0_e5UN6LFU8=PhLkuevK=mCQ>