From owner-freebsd-current Tue Jan 28 1: 4:44 2003 Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C59E137B401 for ; Tue, 28 Jan 2003 01:04:42 -0800 (PST) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6D73C43E4A for ; Tue, 28 Jan 2003 01:04:42 -0800 (PST) (envelope-from bright@elvis.mu.org) Received: by elvis.mu.org (Postfix, from userid 1192) id 3F92AAE2AE; Tue, 28 Jan 2003 01:04:37 -0800 (PST) Date: Tue, 28 Jan 2003 01:04:37 -0800 From: Alfred Perlstein To: current@freebsd.org Subject: LOR fix. Message-ID: <20030128090437.GL85104@elvis.mu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.4i Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Since the locking is wrong anyhow... Index: kern_descrip.c =================================================================== RCS file: /home/ncvs/src/sys/kern/kern_descrip.c,v retrieving revision 1.183 diff -u -r1.183 kern_descrip.c --- kern_descrip.c 21 Jan 2003 20:20:48 -0000 1.183 +++ kern_descrip.c 28 Jan 2003 09:02:56 -0000 @@ -2104,8 +2104,8 @@ PROC_LOCK(p); xf.xf_pid = p->p_pid; xf.xf_uid = p->p_ucred->cr_uid; + PROC_UNLOCK(p); if ((fdp = p->p_fd) == NULL) { - PROC_UNLOCK(p); continue; } FILEDESC_LOCK(fdp); @@ -2125,7 +2125,6 @@ break; } FILEDESC_UNLOCK(fdp); - PROC_UNLOCK(p); if (error) break; } -- -Alfred Perlstein [alfred@freebsd.org] 'Instead of asking why a piece of software is using "1970s technology," start asking why software is ignoring 30 years of accumulated wisdom.' To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message