Date: Fri, 16 Aug 2002 13:37:57 +0300 (EEST) From: Iasen Kostov <ikostov@otel.net> To: Julian Elischer <julian@elischer.org> Cc: Maxim Sobolev <sobomax@FreeBSD.org>, <hackers@FreeBSD.org>, <net@FreeBSD.org> Subject: Re: Increasing size of if_flags field in the ifnet structure [patch for review] Message-ID: <20020816133655.U18061-200000@shadowhand.OTEL.net> In-Reply-To: <20020816131654.H18061-100000@shadowhand.OTEL.net>
next in thread | previous in thread | raw e-mail | index | archive | help
This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. Send mail to mime@docserver.cac.washington.edu for more info. --0-1999923416-1029494277=:18061 Content-Type: TEXT/PLAIN; charset=US-ASCII Ops here is the patch (not enough sleep again :(). On Fri, 16 Aug 2002, Iasen Kostov wrote: > Please take a look at this patch. It implement 1 more flag to if_flags > and ofcourse it increases size of this flag field by using if_ipending > which is unused. > > On Thu, 15 Aug 2002, Julian Elischer wrote: > > > you cannot break ABIs in 4.x > > in 5.x it will probably be ok until (say) 5.1 or something. > > > > > > On Thu, 15 Aug 2002, Maxim Sobolev wrote: > > > > > Folks, > > > > > > When implementing ability to switch interface into promisc mode using > > > ifconfig(8) I've stumbled into the problem with already exhausted > > > space in the `short if_flags' field in the ifnet structure. I need to > > > allocate one new flag, while we already have 16 IFF_* flags, and even > > > one additional flag which is implemented using currently free > > > if_ipending field of the said structure. Attached patch is aimed at > > > increasing size of if_flags to 32 bits, as well as to clean-up > > > if_ipending abuse. Granted, it will break backward ABI compatibility, > > > but IMO it is not a big problem. > > > > > > Comments and suggestions are greatly appreciated. Thanks! > > > > > > -Maxim > > > > > > To Unsubscribe: send mail to majordomo@FreeBSD.org > > with "unsubscribe freebsd-net" in the body of the message > > > > > To Unsubscribe: send mail to majordomo@FreeBSD.org > with "unsubscribe freebsd-net" in the body of the message > --0-1999923416-1029494277=:18061 Content-Type: TEXT/PLAIN; charset=US-ASCII; name="ifcflags.patch" Content-Transfer-Encoding: BASE64 Content-ID: <20020816133757.Y18061@shadowhand.OTEL.net> Content-Description: Content-Disposition: attachment; filename="ifcflags.patch" LS0tIHN5cy9uZXQvaWYuYwlTdW4gQXByIDI4IDA4OjQwOjI1IDIwMDINCisr KyBzeXMvbmV0L2lmLm15LmMJU2F0IEp1biAgOCAyMDo1MjoxMiAyMDAyDQpA QCAtOTUyLDYgKzk1Miw3IEBADQogCXN0cnVjdCBpZnN0YXQgKmlmczsNCiAJ aW50IGVycm9yOw0KIAlzaG9ydCBvaWZfZmxhZ3M7DQorCWludCBmbGFnc2xv bmc7DQogDQogCXN3aXRjaCAoY21kKSB7DQogDQpAQCAtOTgwLDcgKzk4MSw4 IEBADQogCXN3aXRjaCAoY21kKSB7DQogDQogCWNhc2UgU0lPQ0dJRkZMQUdT Og0KLQkJaWZyLT5pZnJfZmxhZ3MgPSBpZnAtPmlmX2ZsYWdzOw0KKwkJZmxh Z3Nsb25nID0gaWZwLT5pZl9mbGFncyAmIDB4MDAwMGZmZmY7DQorCQlpZnIt Pmlmcl9mbGFnc2xvbmcgPSBmbGFnc2xvbmcgfCBpZnAtPmlmX2lwZW5kaW5n Ow0KIAkJYnJlYWs7DQogDQogCWNhc2UgU0lPQ0dJRkNBUDoNCkBAIC0xMDA0 LDYgKzEwMDYsNyBAQA0KIAkJZXJyb3IgPSBzdXNlcihwKTsNCiAJCWlmIChl cnJvcikNCiAJCQlyZXR1cm4gKGVycm9yKTsNCisJCWlmcC0+aWZfaXBlbmRp bmcgPSBpZnItPmlmcl9mbGFnc2xvbmcgJiAweGZmZmYwMDAwOw0KIAkJaWZy LT5pZnJfcHJldmZsYWdzID0gaWZwLT5pZl9mbGFnczsNCiAJCWlmIChpZnAt PmlmX2ZsYWdzICYgSUZGX1NNQVJUKSB7DQogCQkJLyogU21hcnQgZHJpdmVy cyB0d2lkZGxlIHRoZWlyIG93biByb3V0ZXMgKi8NCi0tLSBzeXMvbmV0L2lm LmgJU3VuIEZlYiAxMCAwMTowMjozOSAyMDAyDQorKysgc3lzL25ldC9pZi5t eS5oCVNhdCBKdW4gIDggMjA6NTI6MjAgMjAwMg0KQEAgLTEzOSw2ICsxMzks NyBAQA0KICAqIElGRiBmbGFncywgc28gd2UgaGF2ZSBhbiBlYXNpZXIgdGlt ZSB3aGVuIHdlIHdhbnQgdG8gbWVyZ2UgdGhlbS4NCiAgKi8NCiAjZGVmaW5l CUlGRl9QT0xMSU5HCTB4MTAwMDAJCS8qIEludGVyZmFjZSBpcyBpbiBwb2xs aW5nIG1vZGUuICovDQorI2RlZmluZQlJRkZfTk9ST1VURQkweDIwMDAwCQkv KiBJbnRlcmZhY2UgZG9lc24ndCBuZWVkIGhvc3Qgcm91dGUuICovDQogDQog LyogZmxhZ3Mgc2V0IGludGVybmFsbHkgb25seTogKi8NCiAjZGVmaW5lCUlG Rl9DQU5UQ0hBTkdFIFwNCkBAIC0yMjQsNiArMjI1LDcgQEANCiAJCXN0cnVj dAlzb2NrYWRkciBpZnJ1X2RzdGFkZHI7DQogCQlzdHJ1Y3QJc29ja2FkZHIg aWZydV9icm9hZGFkZHI7DQogCQlzaG9ydAlpZnJ1X2ZsYWdzWzJdOw0KKwkJ aW50CWlmcnVfZmxhZ3Nsb25nOw0KIAkJaW50CWlmcnVfbWV0cmljOw0KIAkJ aW50CWlmcnVfbXR1Ow0KIAkJaW50CWlmcnVfcGh5czsNCkBAIC0yMzYsNiAr MjM4LDcgQEANCiAjZGVmaW5lCWlmcl9icm9hZGFkZHIJaWZyX2lmcnUuaWZy dV9icm9hZGFkZHIJLyogYnJvYWRjYXN0IGFkZHJlc3MgKi8NCiAjZGVmaW5l CWlmcl9mbGFncwlpZnJfaWZydS5pZnJ1X2ZsYWdzWzBdCS8qIGZsYWdzICov DQogI2RlZmluZQlpZnJfcHJldmZsYWdzCWlmcl9pZnJ1LmlmcnVfZmxhZ3Nb MV0JLyogZmxhZ3MgKi8NCisjZGVmaW5lCWlmcl9mbGFnc2xvbmcJaWZyX2lm cnUuaWZydV9mbGFnc2xvbmcJLyogbG9uZyBmbGFncyAoaW50KSAqLw0KICNk ZWZpbmUJaWZyX21ldHJpYwlpZnJfaWZydS5pZnJ1X21ldHJpYwkvKiBtZXRy aWMgKi8NCiAjZGVmaW5lCWlmcl9tdHUJCWlmcl9pZnJ1LmlmcnVfbXR1CS8q IG10dSAqLw0KICNkZWZpbmUgaWZyX3BoeXMJaWZyX2lmcnUuaWZydV9waHlz CS8qIHBoeXNpY2FsIHdpcmUgKi8NCi0tLSBzYmluL2lmY29uZmlnL2lmY29u ZmlnLmMJV2VkIEFwciAgMyAxNDo0ODo0OCAyMDAyDQorKysgc2Jpbi9pZmNv bmZpZy9pZmNvbmZpZy5teS5jCVNhdCBKdW4gIDggMjE6MDU6MDAgMjAwMg0K QEAgLTIwNSw2ICsyMDUsOCBAQA0KIAl7ICItYWxpYXMiLAktSUZGX1VQLAlu b3RlYWxpYXMgfSwNCiAJeyAiZGVsZXRlIiwJLUlGRl9VUCwJbm90ZWFsaWFz IH0sDQogCXsgInJlbW92ZSIsCS1JRkZfVVAsCW5vdGVhbGlhcyB9LA0KKwl7 ICJub3JvdXRlIiwgICAgSUZGX05PUk9VVEUsICAgIHNldGlmZmxhZ3MgfSwN CisJeyAiLW5vcm91dGUiLCAgIC1JRkZfTk9ST1VURSwgICBzZXRpZmZsYWdz IH0sDQogI2lmZGVmIG5vdGRlZg0KICNkZWZpbmUJRU5fU1dBQklQUwkweDEw MDANCiAJeyAic3dhYmlwcyIsCUVOX1NXQUJJUFMsCXNldGlmZmxhZ3MgfSwN CkBAIC0xMDI4LDE0ICsxMDMwLDE0IEBADQogIAkJZXhpdCgxKTsNCiAgCX0N CiAJc3RybmNweShteV9pZnIuaWZyX25hbWUsIG5hbWUsIHNpemVvZiAobXlf aWZyLmlmcl9uYW1lKSk7DQotIAlmbGFncyA9IG15X2lmci5pZnJfZmxhZ3M7 DQorCWZsYWdzID0gbXlfaWZyLmlmcl9mbGFnc2xvbmc7DQogDQogCWlmICh2 YWx1ZSA8IDApIHsNCiAJCXZhbHVlID0gLXZhbHVlOw0KIAkJZmxhZ3MgJj0g fnZhbHVlOw0KIAl9IGVsc2UNCiAJCWZsYWdzIHw9IHZhbHVlOw0KLQlteV9p ZnIuaWZyX2ZsYWdzID0gZmxhZ3M7DQorCW15X2lmci5pZnJfZmxhZ3Nsb25n ID0gZmxhZ3M7DQogCWlmIChpb2N0bChzLCBTSU9DU0lGRkxBR1MsIChjYWRk cl90KSZteV9pZnIpIDwgMCkNCiAJCVBlcnJvcih2bmFtZSk7DQogfQ0KLS0t IHN5cy9uZXRpbmV0L2luLmMJU2F0IEp1biAgOCAyMToyMToxMiAyMDAyDQor Kysgc3lzL25ldGluZXQvaW4ubXkuYwlTYXQgSnVuICA4IDIwOjUzOjA2IDIw MDINCkBAIC03MzksMTUgKzczOSwxNiBAQA0KIAkgKiBYWFg6IFRoaXMgaXMg dWdseSAhICBUaGVyZSBzaG91bGQgYmUgYSB3YXkgZm9yIHRoZSBjYWxsZXIg dG8NCiAJICogICAgICBzYXkgdGhhdCB0aGV5IGRvbid0IHdhbnQgYSBob3N0 IHJvdXRlLg0KIAkgKi8NCi0JaWYgKGlhLT5pYV9hZGRyLnNpbl9hZGRyLnNf YWRkciAhPSBJTkFERFJfQU5ZIHx8DQotCSAgICBpYS0+aWFfbmV0bWFzayAh PSBJTl9DTEFTU0FfTkVUIHx8DQotCSAgICBpYS0+aWFfZHN0YWRkci5zaW5f YWRkci5zX2FkZHIgIT0gaHRvbmwoSU5fQ0xBU1NBX0hPU1QpKSB7DQotCQlp ZiAoKGVycm9yID0gcnRpbml0KCZpYS0+aWFfaWZhLCAoaW50KVJUTV9BREQs IGZsYWdzKSkgIT0gMCkgew0KLQkJCWlhLT5pYV9hZGRyID0gb2xkYWRkcjsN Ci0JCQkgICAgcmV0dXJuIChlcnJvcik7DQotCQl9DQotCQlpYS0+aWFfZmxh Z3MgfD0gSUZBX1JPVVRFOw0KLQl9DQorCWlmICghKGlmcC0+aWZfaXBlbmRp bmcgJiBJRkZfTk9ST1VURSkpDQorCSAgICBpZiAoaWEtPmlhX2FkZHIuc2lu X2FkZHIuc19hZGRyICE9IElOQUREUl9BTlkgfHwNCisJCWlhLT5pYV9uZXRt YXNrICE9IElOX0NMQVNTQV9ORVQgfHwNCisJCWlhLT5pYV9kc3RhZGRyLnNp bl9hZGRyLnNfYWRkciAhPSBodG9ubChJTl9DTEFTU0FfSE9TVCkpIHsNCisJ CSAgICBpZiAoKGVycm9yID0gcnRpbml0KCZpYS0+aWFfaWZhLCAoaW50KVJU TV9BREQsIGZsYWdzKSkgIT0gMCkgew0KKwkJICAgIAlpYS0+aWFfYWRkciA9 IG9sZGFkZHI7DQorCQkJcmV0dXJuIChlcnJvcik7DQorCQkgICAgfQ0KKwkJ ICAgIGlhLT5pYV9mbGFncyB8PSBJRkFfUk9VVEU7DQorCSAgICB9DQogDQog CS8qDQogCSAqIElmIHRoZSBpbnRlcmZhY2Ugc3VwcG9ydHMgbXVsdGljYXN0 LCBqb2luIHRoZSAiYWxsIGhvc3RzIg0K --0-1999923416-1029494277=:18061-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020816133655.U18061-200000>