Date: Tue, 5 Mar 2013 13:40:00 GMT From: Jason Harris <jharris@widomaker.com> To: freebsd-ports-bugs@FreeBSD.org Subject: Re: ports/176439: net/fping: Possible Fping incompatibility with FreeBSD Message-ID: <201303051340.r25De0HR003659@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/176439; it has been noted by GNATS.
From: Jason Harris <jharris@widomaker.com>
To: bug-followup@FreeBSD.org
Cc: Raynaud Alexandre <alexandre.raynaud@sallanches.fr>,
Jason Harris <jharris@widomaker.com>
Subject: Re: ports/176439: net/fping: Possible Fping incompatibility with
FreeBSD
Date: Tue, 5 Mar 2013 09:36:54 -0400
--a8Wt8u1KmwUX3Y2C
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Mon, Mar 04, 2013 at 08:33:43AM -0400, Jason Harris wrote:
> The difference is if the unreachable IP is in the arp cache when fping st=
arts.
> The OP (Raynaud Alexandre) says this causes problems for zabbix, but only=
on FreeBSD.
=20
This [MAINTAINER-approved/written] patch solves the reported inconsistency =
based on
the state of the ARP cache:
%fping 10.0.1.99 ; fping 10.0.1.99 ; fping 10.0.1.99 ; fping 10.0.1.99
10.0.1.99 is unreachable
10.0.1.99 is unreachable
10.0.1.99 is unreachable
10.0.1.99 is unreachable
Note that you need to "mkdir files && mv patch-fping.c files/" and then rei=
nstall fping.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
NotDashEscaped: You need GnuPG to verify this message
diff -r 830ac78f8d7f Makefile
--- a/Makefile Tue Mar 05 08:51:42 2013 -0400
+++ b/Makefile Tue Mar 05 08:53:29 2013 -0400
@@ -8,6 +8,7 @@
=20
PORTNAME=3D fping
PORTVERSION=3D 3.4
+PORTREVISION=3D 1
CATEGORIES=3D net ipv6
MASTER_SITES=3D http://fping.org/dist/
=20
diff -r 830ac78f8d7f files/patch-fping.c
--- /dev/null Thu Jan 01 00:00:00 1970 +0000
+++ b/files/patch-fping.c Tue Mar 05 08:53:29 2013 -0400
@@ -0,0 +1,16 @@
+diff -r c564b3055165 src/fping.c
+--- src/fping.c Tue Mar 05 08:13:11 2013 -0400
++++ src/fping.c Tue Mar 05 08:45:33 2013 -0400
+@@ -1572,7 +1572,11 @@
+ n =3D sendto( s, buffer, ping_pkt_size, 0,
+ ( struct sockaddr* )&h->saddr, sizeof( FPING_SOCKADDR ) );
+=20
+- if( n < 0 || n !=3D ping_pkt_size )
++ if(( n < 0 || n !=3D ping_pkt_size)
++#if defined( EHOSTDOWN )
++ && errno !=3D EHOSTDOWN
++#endif
++ )
+ {
+ if( verbose_flag || unreachable_flag )
+ {
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (FreeBSD)
iJ0EARECAF0FAlE16tJWGGh0dHA6Ly9rZXlzZXJ2ZXIua2pzbC5jb206MTEzNzEv
cGtzL2xvb2t1cD9vcD1nZXQmc2VhcmNoPTB4RDM5REEwRTMmd2VoYXZleW91bm93
PXRydWUACgkQSypIl9OdoOOpngCeM7o5Fiyz+tNd913oIw9eQgx3bFIAnjzizqhw
i0Ah52bnldvJGfXn/nwT
=3DR4KM
-----END PGP SIGNATURE-----
--=20
Jason Harris | PGP: This _is_ PGP-signed, isn't it?
jharris@widomaker.com _|_ Got photons? (TM), (C) 2004
--a8Wt8u1KmwUX3Y2C
Content-Type: application/pgp-signature
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (FreeBSD)
iJ0EARECAF0FAlE19PZWGGh0dHA6Ly9rZXlzZXJ2ZXIua2pzbC5jb206MTEzNzEv
cGtzL2xvb2t1cD9vcD1nZXQmc2VhcmNoPTB4RDM5REEwRTMmd2VoYXZleW91bm93
PXRydWUACgkQSypIl9OdoOP7MwCeMmQFoOgnD34bWP7l17ODaho5N5YAoMFkpHGt
Kp2jHGnSjA71c0iyOMPy
=bmmK
-----END PGP SIGNATURE-----
--a8Wt8u1KmwUX3Y2C--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201303051340.r25De0HR003659>