From owner-freebsd-hackers  Sat Mar 25 15:56:24 2000
Delivered-To: freebsd-hackers@freebsd.org
Received: from orion.ac.hmc.edu (Orion.AC.HMC.Edu [134.173.32.20])
	by hub.freebsd.org (Postfix) with ESMTP id 1CB5737B94C
	for <hackers@FreeBSD.ORG>; Sat, 25 Mar 2000 15:56:20 -0800 (PST)
	(envelope-from brdavis@orion.ac.hmc.edu)
Received: (from brdavis@localhost)
	by orion.ac.hmc.edu (8.8.8/8.8.8) id PAA10184;
	Sat, 25 Mar 2000 15:56:13 -0800 (PST)
Date: Sat, 25 Mar 2000 15:56:11 -0800
From: Brooks Davis <brooks@one-eyed-alien.net>
To: Warner Losh <imp@village.org>
Cc: hackers@FreeBSD.ORG
Subject: Re: Shim Code #error needed
Message-ID: <20000325155611.A18633@orion.ac.hmc.edu>
References: <200003252043.NAA73526@harmony.village.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Mailer: Mutt 1.0pre4i
In-Reply-To: <200003252043.NAA73526@harmony.village.org>; from imp@village.org on Sat, Mar 25, 2000 at 01:43:12PM -0700
Sender: owner-freebsd-hackers@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG

On Sat, Mar 25, 2000 at 01:43:12PM -0700, Warner Losh wrote:
> 
> I've been burned about 6 times now by the shim device support becoming
> optional.  Oh well, that's current.
> 
> However, I was thinking that it would be nice if there was something
> simple to grep for to see what drivers still needed to be converted.
> What would people think of my adding the following to the shim using
> devices:
> 
> cvs diff: Diffing .
> Index: amd.c
> ===================================================================
> RCS file: /home/imp/FreeBSD/CVS/src/sys/pci/amd.c,v
> retrieving revision 1.3
> diff -u -r1.3 amd.c
> --- amd.c       2000/01/14 03:39:30     1.3
> +++ amd.c       2000/03/25 18:07:31
> @@ -50,6 +50,10 @@
>  /* #define AMD_DEBUG0           */
>  /* #define AMD_DEBUG_SCSI_PHASE */
>  
> +#ifndef COMPAT_OLDPCI
> +#error "The amd device requires the old pci compatibility shims"
> +#endif
> +
>  #include <sys/param.h>
>  
>  #include <sys/systm.h>
> 
> At least this way you get a decent error message when it fails to
> work.
> 
> Comments?

I like it.  The new entry in UPDATING should help, but it's easy to
forget and the current errors aren't very obvious.  Don't bother with
tx if you do it though.  I've got a patch I'll probalby submit sometime
today.  It's running without COMPAT_OLDPCI right now, I just want to
take a stab and adding bus_space support while I'm messing around with
it.

-- Brooks

-- 
Any statement of the form "X is the one, true Y" is FALSE.


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-hackers" in the body of the message