From owner-freebsd-current@freebsd.org Sun Jun 3 12:34:25 2018 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 58F6CF75938 for ; Sun, 3 Jun 2018 12:34:25 +0000 (UTC) (envelope-from waitman@waitman.net) Received: from mail2.protonmail.ch (mail2.protonmail.ch [185.70.40.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "*.protonmail.ch", Issuer "QuoVadis Global SSL ICA G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id E308E82B88 for ; Sun, 3 Jun 2018 12:34:24 +0000 (UTC) (envelope-from waitman@waitman.net) Date: Sun, 03 Jun 2018 08:34:13 -0400 To: "freebsd-current@freebsd.org" From: Waitman Gobble Reply-To: Waitman Gobble Subject: Re: Error build nvidia-driver with r334555 Message-ID: In-Reply-To: <20180603122142.GM3789@kib.kiev.ua> References: <83fec8d8-699f-e86c-9884-9d8698a86a91@gmail.com> <20180603120834.GT1389@albert.catwhisker.org> <20180603122142.GM3789@kib.kiev.ua> Feedback-ID: a9EiCCViSiSHQ6Bx5OnM7zSE3j9mdPjjMltovBgA7v_vv_C4nKI9vbMXvmk_xW33cGmibh2zGAa2Co0Llrno4A==:Ext:ProtonMail MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.1 required=5.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU autolearn=ham autolearn_force=no version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on mail.protonmail.ch X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 03 Jun 2018 12:34:25 -0000 =E2=80=8B =E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90 Original Me= ssage =E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90 On June 3, 2018 8:21 AM, Konstantin Belousov wrote: > On Sun, Jun 03, 2018 at 05:08:34AM -0700, David Wolfskill wrote: >=20 > > On Sun, Jun 03, 2018 at 06:48:01PM +0700, Alex V. Petrov wrote: > >=20 > > > .... > > >=20 > > > --- nvidia_subr.o --- > > >=20 > > > nvidia_subr.c:367:26: error: 'memset' call operates on objects of typ= e > > >=20 > > > 'struct nv_ioctl_card_info' while the size is based on a different ty= pe > > >=20 > > > 'struct nv_ioctl_card_info *' [-Werror,-Wsizeof > > >=20 > > > -pointer-memaccess] > > >=20 > > > memset(ci, 0, sizeof(ci)); > > >=20 > > > ~~ ^~ > > >=20 > > > nvidia_subr.c:367:26: note: did you mean to dereference the argument = to > > >=20 > > > 'sizeof' (and multiply it by the number of elements)? > > >=20 > > > memset(ci, 0, sizeof(ci)); > > > ^~ > > > =20 > > >=20 > > > 1 error generated. > > >=20 > > > *** [nvidia_subr.o] Error code 1 > > >=20 > > > .... > >=20 > > Aye; please ref. > >=20 > > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D228709 for > >=20 > > additional details. > >=20 > > The issue has been narrowed down to the range r334529 - r334535; I'm > >=20 > > suspecting r334533 and/or r334534. (Not that the commits are in any way > >=20 > > "faulty" -- merely that the nvidia-driver port may need some "evasive > >=20 > > action" to allow for the change). >=20 > Even not looking at the actual code, I am quite sure that the line >=20 > nvidia_subr.c:367 should be changed to >=20 > memset(ci, 0, sizeof(*ci)); >=20 > This is a bug in the driver sources. >=20 > freebsd-current@freebsd.org mailing list >=20 > https://lists.freebsd.org/mailman/listinfo/freebsd-current >=20 > To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org= " That solved the build problem for me.=20 I haven't noticed any other issues with nvidia driver. Waitman Gobble Sent with ProtonMail Secure Email.=E2=80=8B