From owner-freebsd-stable@FreeBSD.ORG Fri Jun 18 20:05:13 2010 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7EE95106566B for ; Fri, 18 Jun 2010 20:05:13 +0000 (UTC) (envelope-from nlmills@g.clemson.edu) Received: from mail-gx0-f182.google.com (mail-gx0-f182.google.com [209.85.161.182]) by mx1.freebsd.org (Postfix) with ESMTP id 411458FC12 for ; Fri, 18 Jun 2010 20:05:12 +0000 (UTC) Received: by gxk27 with SMTP id 27so1057207gxk.13 for ; Fri, 18 Jun 2010 13:05:12 -0700 (PDT) MIME-Version: 1.0 Received: by 10.101.147.8 with SMTP id z8mr1233689ann.248.1276889961462; Fri, 18 Jun 2010 12:39:21 -0700 (PDT) Received: by 10.100.47.12 with HTTP; Fri, 18 Jun 2010 12:39:21 -0700 (PDT) In-Reply-To: References: Date: Fri, 18 Jun 2010 15:39:21 -0400 Message-ID: From: Nicholas Mills To: freebsd-stable@freebsd.org Content-Type: multipart/mixed; boundary=0016e68deb5791fc6a0489531c99 X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Subject: Fwd: Sysinstall crashes in 8.1-BETA1 X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: nlmills@clemson.edu List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Jun 2010 20:05:13 -0000 --0016e68deb5791fc6a0489531c99 Content-Type: text/plain; charset=ISO-8859-1 Verified to exist in 8.1-RC1. Submitted as PR 147980. ---------- Forwarded message ---------- From: Nicholas Mills Date: Sat, Jun 5, 2010 at 9:01 PM Subject: Sysinstall crashes in 8.1-BETA1 To: randi@freebsd.org Hello, I found and patched a bug in sysinstall(8). My system is running GENERIC 8.1-BETA1 on i386. Initial install went well, but after the system booted I wanted to add some other distributions. However, every time I attempted to connect to an ftp server sysinstall would crash and dump core. I traced the problem down to some uninitialized variables in tcpip.c:tcpDeviceSelect. Attached is my patch. Thanks, Nick Mills nlmills@g.clemson.edu --0016e68deb5791fc6a0489531c99 Content-Type: application/octet-stream; name="tcpip.patch" Content-Disposition: attachment; filename="tcpip.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_ga35yhos0 LS0tIHRjcGlwLmMub2xkCTIwMTAtMDYtMDUgMjA6MTk6MjguMDAwMDAwMDAwIC0wNDAwCisrKyB0 Y3BpcC5jCTIwMTAtMDYtMDUgMjA6MTk6MTEuMDAwMDAwMDAwIC0wNDAwCkBAIC03MzIsNiArNzMy LDkgQEAKIAlyZXR1cm4gKE5VTEwpOwogICAgIH0KIAorICAgIGRldnMgPSBkZXZpY2VGaW5kKE5V TEwsIERFVklDRV9UWVBFX05FVFdPUkspOworICAgIGNudCA9IGRldmljZUNvdW50KGRldnMpOyAK KwogICAgIGlmICgoIVJ1bm5pbmdBc0luaXQpICYmICh2YXJpYWJsZV9jaGVjaygiTkVUV09SS19D T05GSUdVUkVEPU5PIikgIT0gVFJVRSkpIHsKIAlpZiAoIW1zZ1llc05vKCJSdW5uaW5nIG11bHRp LXVzZXIsIGFzc3VtZSB0aGF0IHRoZSBuZXR3b3JrIGlzIGFscmVhZHkgY29uZmlndXJlZD8iKSkK IAkgICAgcmV0dXJuIGRldnNbMF07Cg== --0016e68deb5791fc6a0489531c99--