Date: 12 Feb 2003 19:37:16 +0100 From: Franz Klammer <klammer@webonaut.com> To: Joe Marcus Clarke <marcus@FreeBSD.org> Cc: FreeBSD GNOME Users <gnome@FreeBSD.org> Subject: Re: HEADS UP: Removing GNOMENG Message-ID: <1045075035.663.73.camel@ds9.webonaut.com> In-Reply-To: <1045067568.308.2.camel@gyros> References: <1044991950.305.36.camel@gyros> <1044996271.644.97.camel@ds9.webonaut.com> <1045018703.89844.13.camel@shumai.marcuscom.com> <1045047331.663.10.camel@ds9.webonaut.com> <1045067568.308.2.camel@gyros>
next in thread | previous in thread | raw e-mail | index | archive | help
Am Mi, 2003-02-12 um 17.32 schrieb Joe Marcus Clarke:
> On Wed, 2003-02-12 at 05:55, Franz Klammer wrote:
> > Am Mi, 2003-02-12 um 03.58 schrieb Joe Marcus Clarke:
> > > On Tue, 2003-02-11 at 15:44, Franz Klammer wrote:
> > > > Am Di, 2003-02-11 um 20.32 schrieb Joe Marcus Clarke:
> > > > > Okay, here is my release candidate diff for removing need for the
> > > > > GNOMENG keyword, and adding GNOME 2 support to the new GNOME porting
> > > > > infrastructure. This patch applies directly to ports/Mk/bsd.gnome.mk,
> > > > > and removes the need for the bsd.gnomeng.mk file.
> > > > >
> > > > > I'd like to commit this tomorrow if possible. Please let me know if you
> > > > > see of foresee any problems. Thanks.
> > > > >
> > > >
> > > > work well for me with file_menu_applet.
> > > > i've deleted the older mails about this (maybe you have written about)
> > > > but why you don't include a kind of auto detection as additional safety.
> > >
> > > Give this diff a try. It adds such a check. I haven't done any testing
> > > yet, though.
> > >
> >
> > OK! it works.
> > done test with and without WITH_GNOME_DESKTOP=[1|2] and it works
> > like expected.
>
> I was doing some more thinking about this, and I think setting it for
> the user is a bad idea. Think of the upgrade and downgrade scenarios.
> Let's say the user is upgrading to GNOME 2. They won't have gnomepanel
> installed, but they will have libpanel installed. Therefore, all their
> GNOME 2 desktop bits will be broken.
>
> I think it's safer to force the user to make a conscious decision to
> about which GNOME desktop version they want. This will prevent breakage
> in places we don't want.
>
yes! you are right!
but what do you think about this:
(why make it so easy if there's a harder way? ;-))
1. assuming the user has gnome1 installed and only want
to install/upgrade a gnome1-package. --> auto setting
the same with gnome2
2. for an up- or downgrade --> a descriptive (eye-catcher) message
that he should allow this
explicitly with WITH_GNOME_DESKTOP
in make.conf == forcing
3.a fresh install --> same as point 3
or
3.b fresh install --> use gnome2 as default (X it also defaults to 4)
if the user want install gnome1 back to 3.
franz.
> >
> > FYI: i've only made one test with file_menu_applet.
> > anything else i should check?
>
> Check as much as you can.
>
> Joe
>
> >
> > franz.
> >
> > > Joe
> > >
> > > >
> > > > eg:
> > > >
> > > > (ok! i know, that's not the correct syntax ;)
> > > >
> > > > if !defined(WITH_GNOME_DESKTOP); then
> > > > if exists ../libpanelapplet-2.0.pc; then
> > > > WITH_GNOME_DESKTOP=2
> > > > else
> > > > WITH_GNOME_DESKTOP=1
> > > > endif
> > > > endif
> > > >
> > > > sorry if this mail is a "argh! we already discussed about that!".
> > > > i was too lazy to look into the archive.
> > > >
> > > > attached the patch that removes GNOMENG and the gnome1-check
> > > > from file_menu_applet.
> > > >
> > > > franz.
> > > >
> > > > > Joe
--
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-gnome" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1045075035.663.73.camel>