From owner-freebsd-current Tue Mar 10 01:45:14 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id BAA22924 for freebsd-current-outgoing; Tue, 10 Mar 1998 01:45:14 -0800 (PST) (envelope-from owner-freebsd-current@FreeBSD.ORG) Received: from critter.freebsd.dk ([195.78.64.243]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id BAA22881 for ; Tue, 10 Mar 1998 01:45:11 -0800 (PST) (envelope-from phk@critter.freebsd.dk) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.8.7/8.8.5) with ESMTP id JAA00434; Tue, 10 Mar 1998 09:12:32 +0100 (CET) To: Michael Hancock cc: Dmitrij Tejblum , Terry Lambert , current@FreeBSD.ORG Subject: Re: vnode_pager: *** WARNING *** stale FS code in system In-reply-to: Your message of "Tue, 10 Mar 1998 11:35:19 +0900." Date: Tue, 10 Mar 1998 09:12:32 +0100 Message-ID: <432.889517552@critter.freebsd.dk> From: Poul-Henning Kamp Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG In message , Mich ael Hancock writes: >I think vnode_pager_generic_(put|get)pages should be moved to >vfs_default.c and renamed vop_std(put|get)pages. It would need to be >modified to accept ap instead of 4 components of ap. I agree. >Terry is trying to make it more visible to fs implementors so that they >take the time to understand how to make VM friendly implementations. The >"XXX - wimp out ..." comment is also added for extra emphasis. This >comment should be taken out and replaced by a comment explaining what a VM >friendly (get|put)pages should do. I agree. >I think vfs_default.c is visible enough. If you don't know it is there, you will never get though any kind of VFS work anyway. >This is a form discussion, the substance is the same. My personal opinion >is that it doesn't belong vnode_pager.c because it will tend to be ignored >by fs implementors. It most certainly doesn't belong there. -- Poul-Henning Kamp FreeBSD coreteam member phk@FreeBSD.ORG "Real hackers run -current on their laptop." "Drink MONO-tonic, it goes down but it will NEVER come back up!" To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message