Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 3 Feb 2019 14:55:22 +0000 (UTC)
From:      Oleksandr Tymoshenko <gonzo@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-12@freebsd.org
Subject:   svn commit: r343716 - stable/12/sys/dev/led
Message-ID:  <201902031455.x13EtMAq016708@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: gonzo
Date: Sun Feb  3 14:55:21 2019
New Revision: 343716
URL: https://svnweb.freebsd.org/changeset/base/343716

Log:
  MFC r343029:
  
  [led] propagate error from set_led() to the caller
  
  Do not lose error condition by always returning 0 from set_led.
  None of the calls to set_led checks for return value at the moment so
  none of API consumers in base is affected.
  
  PR:		231567
  Submitted by:	Bertrand Petit <bsdpr@phoe.frmug.org>

Modified:
  stable/12/sys/dev/led/led.c
Directory Properties:
  stable/12/   (props changed)

Modified: stable/12/sys/dev/led/led.c
==============================================================================
--- stable/12/sys/dev/led/led.c	Sun Feb  3 14:54:29 2019	(r343715)
+++ stable/12/sys/dev/led/led.c	Sun Feb  3 14:55:21 2019	(r343716)
@@ -261,7 +261,7 @@ led_set(char const *name, char const *cmd)
 	mtx_unlock(&led_mtx);
 	if (sb != NULL)
 		sbuf_delete(sb);
-	return (0);
+	return (error);
 }
 
 static struct cdevsw led_cdevsw = {



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201902031455.x13EtMAq016708>