Date: Mon, 07 Oct 2002 21:27:19 +0200 From: Poul-Henning Kamp <phk@critter.freebsd.dk> To: John Baldwin <jhb@FreeBSD.org> Cc: cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org Subject: Re: cvs commit: src/sys/boot/i386/btx/btxldr btxldr.s Message-ID: <22628.1034018839@critter.freebsd.dk> In-Reply-To: Your message of "Mon, 07 Oct 2002 15:23:06 EDT." <XFMail.20021007152306.jhb@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <XFMail.20021007152306.jhb@FreeBSD.org>, John Baldwin writes: > >On 07-Oct-2002 Poul-Henning Kamp wrote: >> phk 2002/10/07 12:12:36 PDT >> >> Modified files: >> sys/boot/i386/btx/btxldr btxldr.s >> Log: >> Correctly adjust for moved start address. >> >> It seems that the existence of a "depend" target in src/sys/boot is not >> to be taken as an indication that it actually does what one would expect, >> at least it clearly threw my testing off. > >Well, the problem is that the boot code has a lot of indirect magic numbers >in it and there aren't any real headers that are shared for these various >things to depend on. This stuff is kind of gross. :) I was surprised to see that absolutely no common headers were used, is there a technical reason for that ? Otherwise it would be a nice improvement for the future. The good news in all of this is that it will move the 8k barrier up to 64k so a lot of this code can be written less convoluted once we get there. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?22628.1034018839>