Skip site navigation (1)Skip section navigation (2) 
Date:      Tue, 4 Nov 2008 13:54:07 +0000 (UTC)
From:      Dag-Erling Smorgrav <des@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-projects@freebsd.org
Subject:   svn commit: r184636 - projects/quota64/lib/libutil
Message-ID:  <200811041354.mA4Ds7lg098497@svn.freebsd.org>
next in thread | raw e-mail | index | archive | help 
Author: des
Date: Tue Nov  4 13:54:07 2008
New Revision: 184636
URL: http://svn.freebsd.org/changeset/base/184636

Log:
  MFH (r184633, r184635): build at WARNS level 6

Modified:
  projects/quota64/lib/libutil/Makefile
  projects/quota64/lib/libutil/login_cap.c
  projects/quota64/lib/libutil/login_class.c

Modified: projects/quota64/lib/libutil/Makefile
==============================================================================
--- projects/quota64/lib/libutil/Makefile	Tue Nov  4 13:51:15 2008	(r184635)
+++ projects/quota64/lib/libutil/Makefile	Tue Nov  4 13:54:07 2008	(r184636)
@@ -15,6 +15,8 @@ SRCS=	_secure_path.c auth.c gr_util.c ex
 	stub.c trimdomain.c uucplock.c
 INCS=	libutil.h login_cap.h
 
+WARNS?=	6
+
 CFLAGS+= -DLIBC_SCCS
 
 .if ${MK_INET6_SUPPORT} != "no"

Modified: projects/quota64/lib/libutil/login_cap.c
==============================================================================
--- projects/quota64/lib/libutil/login_cap.c	Tue Nov  4 13:51:15 2008	(r184635)
+++ projects/quota64/lib/libutil/login_cap.c	Tue Nov  4 13:54:07 2008	(r184636)
@@ -61,6 +61,8 @@ static char * internal_string = NULL;
 static size_t internal_arraysz = 0;
 static const char ** internal_array = NULL;
 
+static char path_login_conf[] = _PATH_LOGIN_CONF;
+
 static char *
 allocstr(const char *str)
 {
@@ -215,15 +217,14 @@ login_getclassbyname(char const *name, c
 
 	if (dir && snprintf(userpath, MAXPATHLEN, "%s/%s", dir,
 			    _FILE_LOGIN_CONF) < MAXPATHLEN) {
-	    login_dbarray[i] = userpath;
 	    if (_secure_path(userpath, pwd->pw_uid, pwd->pw_gid) != -1)
-		i++;		/* only use 'secure' data */
+		login_dbarray[i++] = userpath;
 	}
 	/*
 	 * XXX: Why to add the system database if the class is `me'?
 	 */
-	if (_secure_path(_PATH_LOGIN_CONF, 0, 0) != -1)
-	    login_dbarray[i++] = _PATH_LOGIN_CONF;
+	if (_secure_path(path_login_conf, 0, 0) != -1)
+	    login_dbarray[i++] = path_login_conf;
 	login_dbarray[i] = NULL;
 
 	memset(lc, 0, sizeof(login_cap_t));

Modified: projects/quota64/lib/libutil/login_class.c
==============================================================================
--- projects/quota64/lib/libutil/login_class.c	Tue Nov  4 13:51:15 2008	(r184635)
+++ projects/quota64/lib/libutil/login_class.c	Tue Nov  4 13:54:07 2008	(r184636)
@@ -142,14 +142,13 @@ substvar(const char * var, const struct 
 	int	tildes = 0;
 	int	dollas = 0;
 	char	*p;
+	const char *q;
 
 	if (pwd != NULL) {
-	    /* Count the number of ~'s in var to substitute */
-	    for (p = (char *)var; (p = strchr(p, '~')) != NULL; p++)
-		++tildes;
-	    /* Count the number of $'s in var to substitute */
-	    for (p = (char *)var; (p = strchr(p, '$')) != NULL; p++)
-		++dollas;
+	    for (q = var; *q != '\0'; ++q) {
+		tildes += (*q == '~');
+		dollas += (*q == '$');
+	    }
 	}
 
 	np = malloc(strlen(var) + (dollas * nlen)

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200811041354.mA4Ds7lg098497>