Date: Fri, 22 Nov 2013 11:32:26 +0000 From: Ciara Millar <ciarasmillar8@gmail.com> To: freebsd-arm@freebsd.org Subject: www.freebsd.org Message-ID: <089e0118378460293b04ebc25e3c@google.com>
next in thread | raw e-mail | index | archive | help
PGRpdiBkaXI9Imx0ciI+PHNwYW4gIA0Kc3R5bGU9ImZvbnQtZmFtaWx5OmFyaWFsLHNhbnMtc2Vy aWY7Zm9udC1zaXplOjEzcHgiPkhpLDwvc3Bhbj48YnIgIA0Kc3R5bGU9ImZvbnQtZmFtaWx5OmFy aWFsLHNhbnMtc2VyaWY7Zm9udC1zaXplOjEzcHgiPjxkaXYgIA0KY2xhc3M9ImdtYWlsX3F1b3Rl IiAgDQpzdHlsZT0iZm9udC1mYW1pbHk6YXJpYWwsc2Fucy1zZXJpZjtmb250LXNpemU6MTNweCI+ PGRpdiB0ZXh0PSIjMDAwMDAwIiAgDQpiZ2NvbG9yPSIjRkZGRkZGIj4NCjxkaXY+PHA+SSBjYW1l IGFjcm9zcyB5b3VyIHdlYnNpdGUgYW5kIHdhbnRlZCB0byBzZW5kIHlvdSBhIHF1aWNrIG5vdGUu ICANCldpdGggYSBmZXcgc2ltcGxlIGNoYW5nZXMgdG8gbWFrZSB5b3VyIHNpdGUgbW9yZSBTRU8t ZnJpZW5kbHkgSZJtIHN1cmUgeW91ICANCmNhbiBjb252ZXJ0IG1vcmUgdmlzaXRvcnMgaW50byBs ZWFkcyBhbmQgZ2V0IGl0IHBsYWNlZCBoaWdoZXIgaW4gdGhlICANCm9yZ2FuaWMgc2VhcmNoIHJl c3VsdHMsIGZvciBrZXl3b3JkcyB0aGF0IG1hdHRlciB0byB5b3UgdGhlIG1vc3QuPC9wPg0KPC9k aXY+PGRpdj48cD5XZZJyZSBhbiBBdXN0cmFsaWFuIGJhc2VkIGNvbXBhbnkgd2l0aCBhIGdyZWF0 IGluLWhvdXNlICANCnRlY2huaWNhbCB0ZWFtIHdobyByZWFsbHkga25vdyB0aGVpciBzdHVmZiBh Ym91dCBzZWFyY2ggZW5naW5lICANCm9wdGltaXphdGlvbi6gPC9wPjwvZGl2PjxkaXY+PHA+V291 bGQgeW91IGxpa2UgYSBiaXQgbW9yZSBpbmZvcm1hdGlvbiBhYm91dCAgDQpob3cgdG8gZ2l2ZSB5 b3VyIHdlYnNpdGUgYSBib29zdCB3aXRoIGJldHRlciBTRU8/PGJyPg0KPC9wPjwvZGl2PjxkaXY+ PHA+oDwvcD48L2Rpdj48ZGl2PjxwPkJlc3QgUmVnYXJkczwvcD48L2Rpdj48ZGl2PjxwPkNpYXJh ICANCk1pbGxhcjxicj5TRU8vV2ViIFNwZWNpYWxpc3Q8L3A+PC9kaXY+PGRpdj48L2Rpdj48ZGl2 PjxzcGFuICANCnN0eWxlPSJmb250LXNpemU6Ny41cHQiPjwvc3Bhbj48cD48Yj48c3BhbiAgDQpz dHlsZT0iZm9udC1zaXplOjcuNXB0O2NvbG9yOnJnYigxMTEsMTY4LDIyMCkiPkFVUyBIZWFkcXVh cnRlcjxicj4NCjwvc3Bhbj48L2I+PHNwYW4gc3R5bGU9ImZvbnQtc2l6ZTo3LjVwdDtjb2xvcjpy Z2IoMTExLDE2OCwyMjApIj5BdXN0cmFsaWFuICANClRlY2hub2xvZ3kgUGFyaywgTG9jb21vdGl2 ZSBTdHJlZXQsIEV2ZWxlaWdooDxicj5OU1cgIA0KMjAxNTxicj48Yj48YnI+SW50ZXJuYXRpb25h bCBIZWFkcXVhcnRlcjxicj48L2I+NTAxIDE5dGggU3RyZWV0LCBOLlcuLCAgDQpXYXNoaW5ndG9u LCBELkMuIDIwNDMxPC9zcGFuPjwvcD4NCjwvZGl2PjwvZGl2PjwvZGl2PjwvZGl2Pg0K From owner-freebsd-arm@FreeBSD.ORG Fri Nov 22 16:56:29 2013 Return-Path: <owner-freebsd-arm@FreeBSD.ORG> Delivered-To: arm@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 7426042F for <arm@FreeBSD.ORG>; Fri, 22 Nov 2013 16:56:29 +0000 (UTC) Received: from kanar.ci0.org (kanar.ci0.org [88.191.150.159]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id D8FA620A6 for <arm@FreeBSD.ORG>; Fri, 22 Nov 2013 16:56:25 +0000 (UTC) Received: from kanar.ci0.org (pluxor@localhost [127.0.0.1]) by kanar.ci0.org (8.14.5/8.14.5) with ESMTP id rAMGhx0c015521; Fri, 22 Nov 2013 17:43:59 +0100 (CET) (envelope-from cognet@ci0.org) Received: (from doginou@localhost) by kanar.ci0.org (8.14.5/8.14.5/Submit) id rAMGhwp5015520; Fri, 22 Nov 2013 17:43:58 +0100 (CET) (envelope-from cognet@ci0.org) X-Authentication-Warning: kanar.ci0.org: doginou set sender to cognet@ci0.org using -f Date: Fri, 22 Nov 2013 17:43:58 +0100 From: Olivier Houchard <cognet@ci0.org> To: Ruslan Bukin <br@bsdpad.com> Subject: Re: arm SMP fix Message-ID: <20131122164358.GA15486@ci0.org> References: <20131122000457.GA44039@freebsd.org> <20131122072140.GA709@mail.bsdpad.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20131122072140.GA709@mail.bsdpad.com> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: arm@FreeBSD.ORG X-BeenThere: freebsd-arm@freebsd.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: Porting FreeBSD to the StrongARM Processor <freebsd-arm.freebsd.org> List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-arm>, <mailto:freebsd-arm-request@freebsd.org?subject=unsubscribe> List-Archive: <http://lists.freebsd.org/pipermail/freebsd-arm/>; List-Post: <mailto:freebsd-arm@freebsd.org> List-Help: <mailto:freebsd-arm-request@freebsd.org?subject=help> List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arm>, <mailto:freebsd-arm-request@freebsd.org?subject=subscribe> X-List-Received-Date: Fri, 22 Nov 2013 16:56:29 -0000 On Fri, Nov 22, 2013 at 11:21:40AM +0400, Ruslan Bukin wrote: > On Fri, Nov 22, 2013 at 12:04:57AM +0000, Olivier Houchard wrote: > > Hi all, > > > > Attached is the first draft to a patch that fixes SMP for me, it seems to > > work fine on my Pandaboard. > > The problem is, as it is currently implemented, curthread is basically > > defined as get_pcpu()->pc_curthread. If we get interrupted between the moment > > we got the struct pcpu, and the moment we derefence it to get the curthread > > pointer, and migrated to another core, we would get the wrong curthread, and > > that's not good. > > The proposed fix does the following : > > - use the register we used to use for pcpu for curthread > > - get the pcpu address by reading the cpu id from the CPUID register, and > > just use it as an index for the __pcpu array. > > > > It breaks the KBI, which is unfortunate, but I think it is no big deal for > > arm right now. > > > > Any review, comment, and testing, even on UP boards, would be very welcome. > > > > Regards, > > > > Olivier > > what type of media for root you used? > > just a quick test on exynos5250 > > one time I booted OK with patch and SMP enabled, > two other attempts got panics > (probably during usb ethernet load) > > http://pastebin.com/H129SMKX > http://pastebin.com/szkBjaT5 > Hi, I'm netbooting using the Pandaboard usb ethernet adapter too. As you're not alone in reporting that my patch doesn't work, I guess I can't just pretend it's your fault :) Are you getting the same thing without the patch ? Regards, Olivier
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?089e0118378460293b04ebc25e3c>