Date: Fri, 31 Jul 2009 10:00:29 -0700 From: Sam Leffler <sam@errno.com> To: Ed Schouten <ed@80386.nl> Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org, Rui Paulo <rpaulo@FreeBSD.org> Subject: Re: svn commit: r195907 - in head/sys: amd64/amd64 i386/i386 Message-ID: <4A73232D.8050605@errno.com> In-Reply-To: <20090731150328.GN1292@hoeg.nl> References: <200907271351.n6RDptNX002239@svn.freebsd.org> <20090731150328.GN1292@hoeg.nl>
next in thread | previous in thread | raw e-mail | index | archive | help
Ed Schouten wrote:
> * Rui Paulo <rpaulo@FreeBSD.org> wrote:
>> Refine the MacBook hack to only match early models that have Intel ICH.
> ...
>> - if (strncmp(sysenv, "MacBook", 7) == 0) {
>> + if (strncmp(sysenv, "MacBook1,1", 10) == 0 ||
>> + strncmp(sysenv, "MacBookPro1,1", 13) == 0 ||
>> + strncmp(sysenv, "MacBookPro1,2", 13) == 0 ||
>> + strncmp(sysenv, "Macmini1,1", 10) == 0) {
>
> Yay -- this change broke FreeBSD on my MacBook3,1. Could we please add
> MacBook3,1 to this list before releasing 8.0?
>
A hack like this deserves a loader tunable to set the list or, perhaps
easier, an extra model ID to allow workaround w/o rebuilding (e.g. for
doing an install).
Sam
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4A73232D.8050605>