Date: Wed, 24 Jul 2013 18:13:43 +0000 (UTC) From: Marcel Moolenaar <marcel@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r253617 - head/sys/kern Message-ID: <201307241813.r6OIDhpH069069@svn.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: marcel Date: Wed Jul 24 18:13:43 2013 New Revision: 253617 URL: http://svnweb.freebsd.org/changeset/base/253617 Log: Further restrict the MAC addresses that we use for UUID generation to those that are universally administered. While it is possible to add locally administered MAC addresses, it's unclear whether those are (expected) to be more unique than random multicast MAC addresses or not. With many U-Boot configurations assigning fixed and non-official MAC addresses to ethernet ports and without setting the 'X' flag, this change may have very little value in the embedded (development) space. Uniqueness of the universally administered addresses is non- existent on the (H/W) bench and questionable under the (S/W) desk. In short: this change is aimed at production environments... Modified: head/sys/kern/kern_uuid.c Modified: head/sys/kern/kern_uuid.c ============================================================================== --- head/sys/kern/kern_uuid.c Wed Jul 24 17:55:08 2013 (r253616) +++ head/sys/kern/kern_uuid.c Wed Jul 24 18:13:43 2013 (r253617) @@ -203,10 +203,10 @@ uuid_ether_add(const uint8_t *addr) int i, sum; /* - * Validate input. No multicast addresses and no addresses that - * are all zeroes. + * Validate input. No multicast (flag 0x1), no locally administered + * (flag 0x2) and no 'all-zeroes' addresses. */ - if (addr[0] & 0x01) + if (addr[0] & 0x03) return (EINVAL); sum = 0; for (i = 0; i < UUID_NODE_LEN; i++)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201307241813.r6OIDhpH069069>