From owner-freebsd-current@FreeBSD.ORG Thu Apr 16 09:52:14 2009 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A827D106566B for ; Thu, 16 Apr 2009 09:52:14 +0000 (UTC) (envelope-from M.S.Powell@salford.ac.uk) Received: from airy.salford.ac.uk (airy.salford.ac.uk [146.87.0.11]) by mx1.freebsd.org (Postfix) with SMTP id 374158FC0C for ; Thu, 16 Apr 2009 09:52:13 +0000 (UTC) (envelope-from M.S.Powell@salford.ac.uk) Received: (qmail 58273 invoked by uid 98); 16 Apr 2009 10:52:12 +0100 Received: from 146.87.255.121 by airy.salford.ac.uk (envelope-from , uid 401) with qmail-scanner-2.01 (clamdscan: 0.94.2/9245. spamassassin: 3.2.4. Clear:RC:1(146.87.255.121):. Processed in 0.043905 secs); 16 Apr 2009 09:52:12 -0000 Received: from rust.salford.ac.uk (HELO rust.salford.ac.uk) (146.87.255.121) by airy.salford.ac.uk (qpsmtpd/0.3x.614) with SMTP; Thu, 16 Apr 2009 10:52:12 +0100 Received: (qmail 91751 invoked by uid 1002); 16 Apr 2009 09:52:10 -0000 Received: from localhost (sendmail-bs@127.0.0.1) by localhost with SMTP; 16 Apr 2009 09:52:10 -0000 Date: Thu, 16 Apr 2009 10:52:10 +0100 (BST) From: "Mark Powell" To: "James R. Van Artsdalen" In-Reply-To: <49E69F7C.9020402@jrv.org> Message-ID: <20090416104803.O88758@rust.salford.ac.uk> References: <49E4CED7.2040206@jrv.org> <49E69F7C.9020402@jrv.org> MIME-Version: 1.0 Content-Type: MULTIPART/MIXED; BOUNDARY="0-1115800636-1239875530=:88758" Cc: freebsd-current@freebsd.org Subject: Re: ata FLUSHCACHE timeout errors? [patch] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Apr 2009 09:52:15 -0000 This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --0-1115800636-1239875530=:88758 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed On Wed, 15 Apr 2009, James R. Van Artsdalen wrote: > James R. Van Artsdalen wrote: >> I am getting many FLUSHCACHE timeout errors during "zfs recv" operations. > > This patch fixes this. PR to be filed. > In addition this causes any ata request that times out to print the > timeout, since it's going to be the timeout itself that's likely wrong. This is well known and had been repeated ad. inf.. Problem is, it never got addressed: http://wiki.freebsd.org/JeremyChadwick/ATA_issues_and_troubleshooting Attached is an 8-CURRENT patch which makes the ata timeout a tuneable. Shamelessy ripped off the FreeNAS patch on the above url. Cheers. -- Mark Powell - UNIX System Administrator - The University of Salford Information & Learning Services, Clifford Whitworth Building, Salford University, Manchester, M5 4WT, UK. Tel: +44 161 295 6843 Fax: +44 161 295 5888 www.pgp.com for PGP key --0-1115800636-1239875530=:88758 Content-Type: TEXT/PLAIN; charset=US-ASCII; name=patch.ata_to.fbsd8.diff Content-Transfer-Encoding: BASE64 Content-ID: <20090416105210.R88758@rust.salford.ac.uk> Content-Description: Content-Disposition: attachment; filename=patch.ata_to.fbsd8.diff LS0tIGF0YS1hbGwuYy5vcmlnCTIwMDktMDMtMTkgMTQ6MDA6MzYuMDAwMDAw MDAwICswMDAwDQorKysgYXRhLWFsbC5jCTIwMDktMDMtMTkgMTQ6MDQ6NTUu MDAwMDAwMDAwICswMDAwDQpAQCAtNzUsNiArNzUsNyBAQA0KIHVtYV96b25l X3QgYXRhX3JlcXVlc3Rfem9uZTsNCiB1bWFfem9uZV90IGF0YV9jb21wb3Np dGVfem9uZTsNCiBpbnQgYXRhX3djID0gMTsNCitpbnQgYXRhX3RvID0gNTsN CiBpbnQgYXRhX3NldG1heCA9IDA7DQogaW50IGF0YV9kbWFfY2hlY2tfODBw aW4gPSAxOw0KIA0KQEAgLTk3LDYgKzk4LDkgQEANCiBUVU5BQkxFX0lOVCgi aHcuYXRhLndjIiwgJmF0YV93Yyk7DQogU1lTQ1RMX0lOVChfaHdfYXRhLCBP SURfQVVUTywgd2MsIENUTEZMQUdfUkRUVU4sICZhdGFfd2MsIDAsDQogCSAg ICJBVEEgZGlzayB3cml0ZSBjYWNoaW5nIik7DQorVFVOQUJMRV9JTlQoImh3 LmF0YS50byIsICZhdGFfdG8pOw0KK1NZU0NUTF9JTlQoX2h3X2F0YSwgT0lE X0FVVE8sIHRvLCBDVExGTEFHX1JXLCAmYXRhX3RvLCAwLA0KKwkgICAiQVRB IGRpc2sgdGltZW91dCB2aXMtYS12aXMgcG93ZXItc2F2aW5nIik7DQogVFVO QUJMRV9JTlQoImh3LmF0YS5zZXRtYXgiLCAmYXRhX3NldG1heCk7DQogU1lT Q1RMX0lOVChfaHdfYXRhLCBPSURfQVVUTywgc2V0bWF4LCBDVExGTEFHX1JE VFVOLCAmYXRhX3NldG1heCwgMCwNCiAJICAgIkFUQSBkaXNrIHNldCBtYXgg bmF0aXZlIGFkZHJlc3MiKTsNCi0tLSBhdGEtYWxsLmgub3JpZwkyMDA5LTAz LTE5IDE0OjAwOjM2LjAwMDAwMDAwMCArMDAwMA0KKysrIGF0YS1hbGwuaAky MDA5LTAzLTE5IDE0OjA1OjMxLjAwMDAwMDAwMCArMDAwMA0KQEAgLTU0NSw2 ICs1NDUsNyBAQA0KIGV4dGVybiBzdHJ1Y3QgaW50cl9jb25maWdfaG9vayAq YXRhX2RlbGF5ZWRfYXR0YWNoOw0KIGV4dGVybiBkZXZjbGFzc190IGF0YV9k ZXZjbGFzczsNCiBleHRlcm4gaW50IGF0YV93YzsNCitleHRlcm4gaW50IGF0 YV90bzsNCiBleHRlcm4gaW50IGF0YV9zZXRtYXg7DQogZXh0ZXJuIGludCBh dGFfZG1hX2NoZWNrXzgwcGluOw0KIA0KLS0tIGF0YS1kaXNrLmMub3JpZwky MDA5LTAzLTE5IDE0OjAwOjM2LjAwMDAwMDAwMCArMDAwMA0KKysrIGF0YS1k aXNrLmMJMjAwOS0wMy0xOSAxNDowNjo0MS4wMDAwMDAwMDAgKzAwMDANCkBA IC0yMzAsNyArMjMwLDcgQEANCiAgICAgfQ0KICAgICByZXF1ZXN0LT5kZXYg PSBkZXY7DQogICAgIHJlcXVlc3QtPmZsYWdzID0gQVRBX1JfQ09OVFJPTDsN Ci0gICAgcmVxdWVzdC0+dGltZW91dCA9IDU7DQorICAgIHJlcXVlc3QtPnRp bWVvdXQgPSBhdGFfdG87DQogICAgIHJlcXVlc3QtPnJldHJpZXMgPSAxOw0K ICAgICByZXF1ZXN0LT5jYWxsYmFjayA9IGFkX3Bvd2VyX2NhbGxiYWNrOw0K ICAgICByZXF1ZXN0LT51LmF0YS5jb21tYW5kID0gQVRBX1NUQU5EQllfSU1N RURJQVRFOw0KQEAgLTI2NSw3ICsyNjUsNyBAQA0KIAlyZXF1ZXN0LT50aW1l b3V0ID0gMzE7DQogICAgIH0NCiAgICAgZWxzZSB7DQotCXJlcXVlc3QtPnRp bWVvdXQgPSA1Ow0KKwlyZXF1ZXN0LT50aW1lb3V0ID0gYXRhX3RvOw0KICAg ICB9DQogICAgIHJlcXVlc3QtPnJldHJpZXMgPSAyOw0KICAgICByZXF1ZXN0 LT5kYXRhID0gYnAtPmJpb19kYXRhOw0KQEAgLTQ2MCw3ICs0NjAsNyBAQA0K ICAgICByZXF1ZXN0LT51LmF0YS5jb3VudCA9IDA7DQogICAgIHJlcXVlc3Qt PnUuYXRhLmZlYXR1cmUgPSAwOw0KICAgICByZXF1ZXN0LT5mbGFncyA9IEFU QV9SX0NPTlRST0wgfCBBVEFfUl9RVUlFVDsNCi0gICAgcmVxdWVzdC0+dGlt ZW91dCA9IDU7DQorICAgIHJlcXVlc3QtPnRpbWVvdXQgPSBhdGFfdG87DQog ICAgIHJlcXVlc3QtPnJldHJpZXMgPSAwOw0KICAgICBhdGFfcXVldWVfcmVx dWVzdChyZXF1ZXN0KTsNCiAgICAgaWYgKHJlcXVlc3QtPnN0YXR1cyAmIEFU QV9TX0VSUk9SKQ0KQEAgLTQ3OSw3ICs0NzksNyBAQA0KICAgICByZXF1ZXN0 LT51LmF0YS5jb3VudCA9IDE7DQogICAgIHJlcXVlc3QtPnUuYXRhLmZlYXR1 cmUgPSAwOw0KICAgICByZXF1ZXN0LT5mbGFncyA9IEFUQV9SX0NPTlRST0w7 DQotICAgIHJlcXVlc3QtPnRpbWVvdXQgPSA1Ow0KKyAgICByZXF1ZXN0LT50 aW1lb3V0ID0gYXRhX3RvOw0KICAgICByZXF1ZXN0LT5yZXRyaWVzID0gMDsN CiAgICAgYXRhX3F1ZXVlX3JlcXVlc3QocmVxdWVzdCk7DQogICAgIGlmIChy ZXF1ZXN0LT5zdGF0dXMgJiBBVEFfU19FUlJPUikNCg== --0-1115800636-1239875530=:88758--