Date: Tue, 17 Dec 2002 12:33:34 -0500 (EST) From: John Baldwin <jhb@FreeBSD.org> To: Bosko Milekic <bmilekic@unixdaemons.com> Cc: cvs-all@FreeBSD.ORG, cvs-committers@FreeBSD.ORG, Maxim Konovalov <maxim@FreeBSD.ORG>, Robert Watson <rwatson@FreeBSD.ORG>, Matthew Dillon <dillon@apollo.backplane.com>, Hiten Pandya <hiten@angelica.unixdaemons.com> Subject: Re: cvs commit: src/sys/netinet ip_dummynet.c Message-ID: <XFMail.20021217123334.jhb@FreeBSD.org> In-Reply-To: <20021215142734.A37709@unixdaemons.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 15-Dec-2002 Bosko Milekic wrote: > > > On Sun, Dec 15, 2002 at 02:13:49PM -0500, Hiten Pandya wrote: >> On Sun, Dec 15, 2002 at 10:06:33AM -0800, Matthew Dillon wrote the words in effect of: >> > We had similar problems with the B_ flags. I recommend changing all the >> > mbuf flags from M_ to MB_, and perhaps rename the MB_ defines in >> > sys/mchain.h to MC_ or MBC_. >> > >> > -Matt >> >> That was on the tip of my tongue! :) This also makes it easier to >> distinguish between the flags easily, and stops confusion. I am prepared >> to do the dirty work, if given the go ahead... but not anytime before >> christmas. :) > > You people realize that you're going to have 123019301293 people > yelling at you for breaking 'compatibility' with the other BSDs? I > won't be one of those 123019301293 people, but rest assured that they > do lurk around these parts. You can add compat macros for other BSD's or some such. Using overly simple namespaces is just asking for confusion. We've already seen other instances due to the ambiguity of MSIZE. m_* can mean meany things, but mb_* or mbuf_* means a lot fewer. When BSD/OS first gave us their mutex code all the MTX_* macros were M_*, but we changed it to MTX_* to avoid exactly this type of situation and BSD/OS changed their macro names as well. -- John Baldwin <jhb@FreeBSD.org> <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.20021217123334.jhb>