Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 13 Jan 2002 16:30:59 -0800
From:      Alfred Perlstein <bright@mu.org>
To:        Bruce Evans <bde@zeta.org.au>
Cc:        John Baldwin <jhb@FreeBSD.ORG>, smp@FreeBSD.ORG, dillon@FreeBSD.ORG, tanimura@FreeBSD.ORG
Subject:   Re: fd locking.
Message-ID:  <20020113163059.V7984@elvis.mu.org>
In-Reply-To: <20020114110256.Q3471-100000@gamplex.bde.org>; from bde@zeta.org.au on Mon, Jan 14, 2002 at 11:13:47AM %2B1100
References:  <20020113052807.R7984@elvis.mu.org> <20020114110256.Q3471-100000@gamplex.bde.org>

next in thread | previous in thread | raw e-mail | index | archive | help
* Bruce Evans <bde@zeta.org.au> [020113 16:13] wrote:
> On Sun, 13 Jan 2002, Alfred Perlstein wrote:
> 
> > * Alfred Perlstein <bright@mu.org> [020113 04:10] wrote:
> > > * Alfred Perlstein <bright@mu.org> [020112 19:17] wrote:
> > > > * John Baldwin <jhb@FreeBSD.org> [020112 19:00] wrote:
> > >
> > > > > Bruce is going to not like you for adding nested includes of sys/lock.h and
> > > > > sys/mutex.h.  Instead, add nested includes of sys/_lock.h and sys/_mutex.h, and
> > > > > then add sys/lock.h and sys/mutex.h to the files that need them.
> > > >
> > > > Can this be delayed?
> 
> No.

Heh, I didn't mean for more than a couple of hours.  I think I already
cleaned it up.

> > >
> > > I'll start on this.
> >
> > Ugh, what a pain!
> >
> > Basically I wind up with an annoying problem.  I want fhold and fhold_locked
> > to be inlines.  However they use mutexes, _however_, they aren't used for
> > the most part, __however__ a lot of people include these files...
> 
> This shows that they shouldn't be inlines, at least in the bloated case
> where the mutex functions are used.  Don't add includes of <sys/mutex.h>
> all over to "fix" this.

This is all taken care of now, let me know if it's ok.

-- 
-Alfred Perlstein [alfred@freebsd.org]
'Instead of asking why a piece of software is using "1970s technology,"
 start asking why software is ignoring 30 years of accumulated wisdom.'
Tax deductable donations for FreeBSD: http://www.freebsdfoundation.org/

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-smp" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020113163059.V7984>