From owner-freebsd-smp Sun Jan 13 16:31: 4 2002 Delivered-To: freebsd-smp@freebsd.org Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by hub.freebsd.org (Postfix) with ESMTP id 332DF37B402; Sun, 13 Jan 2002 16:30:59 -0800 (PST) Received: by elvis.mu.org (Postfix, from userid 1192) id 0A71310DDFB; Sun, 13 Jan 2002 16:30:59 -0800 (PST) Date: Sun, 13 Jan 2002 16:30:59 -0800 From: Alfred Perlstein To: Bruce Evans Cc: John Baldwin , smp@FreeBSD.ORG, dillon@FreeBSD.ORG, tanimura@FreeBSD.ORG Subject: Re: fd locking. Message-ID: <20020113163059.V7984@elvis.mu.org> References: <20020113052807.R7984@elvis.mu.org> <20020114110256.Q3471-100000@gamplex.bde.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <20020114110256.Q3471-100000@gamplex.bde.org>; from bde@zeta.org.au on Mon, Jan 14, 2002 at 11:13:47AM +1100 Sender: owner-freebsd-smp@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org * Bruce Evans [020113 16:13] wrote: > On Sun, 13 Jan 2002, Alfred Perlstein wrote: > > > * Alfred Perlstein [020113 04:10] wrote: > > > * Alfred Perlstein [020112 19:17] wrote: > > > > * John Baldwin [020112 19:00] wrote: > > > > > > > > Bruce is going to not like you for adding nested includes of sys/lock.h and > > > > > sys/mutex.h. Instead, add nested includes of sys/_lock.h and sys/_mutex.h, and > > > > > then add sys/lock.h and sys/mutex.h to the files that need them. > > > > > > > > Can this be delayed? > > No. Heh, I didn't mean for more than a couple of hours. I think I already cleaned it up. > > > > > > I'll start on this. > > > > Ugh, what a pain! > > > > Basically I wind up with an annoying problem. I want fhold and fhold_locked > > to be inlines. However they use mutexes, _however_, they aren't used for > > the most part, __however__ a lot of people include these files... > > This shows that they shouldn't be inlines, at least in the bloated case > where the mutex functions are used. Don't add includes of > all over to "fix" this. This is all taken care of now, let me know if it's ok. -- -Alfred Perlstein [alfred@freebsd.org] 'Instead of asking why a piece of software is using "1970s technology," start asking why software is ignoring 30 years of accumulated wisdom.' Tax deductable donations for FreeBSD: http://www.freebsdfoundation.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-smp" in the body of the message