Skip site navigation (1)Skip section navigation (2) 
Date:      Wed, 15 May 2013 01:06:24 +0000 (UTC)
From:      Pyun YongHyeon <yongari@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-8@freebsd.org
Subject:   svn commit: r250647 - stable/8/sys/dev/sis
Message-ID:  <201305150106.r4F16OZX080158@svn.freebsd.org>
next in thread | raw e-mail | index | archive | help 
Author: yongari
Date: Wed May 15 01:06:24 2013
New Revision: 250647
URL: http://svnweb.freebsd.org/changeset/base/250647

Log:
  MFC r248456:
    r119712 introduced SIS_TYPE_83816 but it was not actually set in
    driver such that checking against the type was always false.
    To detect NS DP83816, driver should have checked silicon revision
    register for NS controllers. While here, remove SIS_TYPE_83816 to
    not make the similar mistake again.

Modified:
  stable/8/sys/dev/sis/if_sis.c
  stable/8/sys/dev/sis/if_sisreg.h
Directory Properties:
  stable/8/sys/   (props changed)
  stable/8/sys/dev/   (props changed)
  stable/8/sys/dev/sis/   (props changed)

Modified: stable/8/sys/dev/sis/if_sis.c
==============================================================================
--- stable/8/sys/dev/sis/if_sis.c	Wed May 15 01:05:16 2013	(r250646)
+++ stable/8/sys/dev/sis/if_sis.c	Wed May 15 01:06:24 2013	(r250647)
@@ -628,7 +628,7 @@ sis_miibus_statchg(device_t dev)
 		SIS_CLRBIT(sc, SIS_RX_CFG, SIS_RXCFG_RX_TXPKTS);
 	}
 
-	if (sc->sis_type == SIS_TYPE_83816) {
+	if (sc->sis_type == SIS_TYPE_83815 && sc->sis_srr >= NS_SRR_16A) {
 		/*
 		 * MPII03.D: Half Duplex Excessive Collisions.
 		 * Also page 49 in 83816 manual
@@ -1993,7 +1993,7 @@ sis_initl(struct sis_softc *sc)
 		return;
 	}
 
-	if (sc->sis_type == SIS_TYPE_83815 || sc->sis_type == SIS_TYPE_83816) {
+	if (sc->sis_type == SIS_TYPE_83815) {
 		if (sc->sis_manual_pad != 0)
 			sc->sis_flags |= SIS_FLAG_MANUAL_PAD;
 		else

Modified: stable/8/sys/dev/sis/if_sisreg.h
==============================================================================
--- stable/8/sys/dev/sis/if_sisreg.h	Wed May 15 01:05:16 2013	(r250646)
+++ stable/8/sys/dev/sis/if_sisreg.h	Wed May 15 01:06:24 2013	(r250647)
@@ -439,7 +439,6 @@ struct sis_type {
 #define SIS_TYPE_900	1
 #define SIS_TYPE_7016	2
 #define SIS_TYPE_83815	3
-#define SIS_TYPE_83816	4
 
 struct sis_txdesc {
 	struct mbuf		*tx_m;

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201305150106.r4F16OZX080158>