From owner-cvs-ports@FreeBSD.ORG Wed Jan 23 19:32:00 2008 Return-Path: Delivered-To: cvs-ports@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id DD80A16A41B for ; Wed, 23 Jan 2008 19:32:00 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from mail2.fluidhosting.com (mx21.fluidhosting.com [204.14.89.4]) by mx1.freebsd.org (Postfix) with SMTP id 73ABA13C47E for ; Wed, 23 Jan 2008 19:32:00 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: (qmail 23439 invoked by uid 399); 23 Jan 2008 19:31:58 -0000 Received: from localhost (HELO ?192.168.0.4?) (dougb@dougbarton.us@127.0.0.1) by localhost with ESMTP; 23 Jan 2008 19:31:58 -0000 X-Originating-IP: 127.0.0.1 Message-ID: <47979627.1060405@FreeBSD.org> Date: Wed, 23 Jan 2008 11:31:51 -0800 From: Doug Barton Organization: http://www.FreeBSD.org/ User-Agent: Thunderbird 2.0.0.9 (Windows/20071031) MIME-Version: 1.0 To: Rong-En Fan , ports-committers@FreeBSD.org, cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org References: <200801200837.m0K8bNX0081391@repoman.freebsd.org> <4795044E.6030006@FreeBSD.org> <20080122015108.GX4650@svm.csie.ntu.edu.tw> <20080122215109.GD21985@tirith.brixandersen.dk> In-Reply-To: <20080122215109.GD21985@tirith.brixandersen.dk> X-Enigmail-Version: 0.95.6 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Subject: Re: cvs commit: ports/sysutils/LPRng Makefile distinfo pkg-descr pkg-plist ports/sysutils/LPRng/files lprng.in pkg-message.in X-BeenThere: cvs-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jan 2008 19:32:01 -0000 Henrik Brix Andersen wrote: > On Tue, Jan 22, 2008 at 09:51:08AM +0800, Rong-En Fan wrote: >> On Mon, Jan 21, 2008 at 12:45:02PM -0800, Doug Barton wrote: >>> The script looks good, thanks for doing this! The only thing I would point >>> out is that the default _enable=no is not needed, since rc.subr needs to >>> see one of the values for "yes" in order to do anything. No harm leaving it >>> in, I just wanted to point out that it's not strictly necessary. >> Thanks. I see most of our /etc/rc.d/* scripts does not have this. >> But most ports' have as our Porter's Handbook have such example. > > I believe this is actually required for rc scripts supplied by > ports. Scripts included in the base wont need it, since their default > settings are already present in /etc/defaults/rc.conf. > > I just tried removing the default setting for '$bitlbee_enable' in the > rc script for irc/bitlbee, I did recently. It then results in the > following error when '$bitlbee_enable' is undefined: > > # /usr/local/etc/rc.d/bitlbee rcvar > # bitlbee > /usr/local/etc/rc.d/bitlbee: WARNING: $bitlbee_enable is not set properly - see rc.conf(5). > bitlbee_enable=NO Hrrm, that's annoying. :) Ignore what I said then, if it's doing that (and I don't think it _should_, but that's another issue) then you need the default. Sorry for the noise. Doug -- This .signature sanitized for your protection