From owner-freebsd-stable Thu May 9 5:17:41 2002 Delivered-To: freebsd-stable@freebsd.org Received: from isris.pair.com (isris.pair.com [209.68.2.39]) by hub.freebsd.org (Postfix) with SMTP id 248AC37B405 for ; Thu, 9 May 2002 05:17:36 -0700 (PDT) Received: (qmail 66468 invoked by uid 3130); 9 May 2002 12:17:34 -0000 Date: Thu, 9 May 2002 08:17:34 -0400 From: Garrett Rooney To: Dmitry Morozovsky Cc: stable@freebsd.org Subject: Re: ports/devel/apr-devel broken for last 3 days Message-ID: <20020509121734.GA66106@electricjellyfish.net> References: <20020509133414.V6600-100000@woozle.rinet.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20020509133414.V6600-100000@woozle.rinet.ru> User-Agent: Mutt/1.3.25i Sender: owner-freebsd-stable@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Thu, May 09, 2002 at 02:49:27PM +0400, Dmitry Morozovsky wrote: > Hi there colleagues, > > devel/apr-devel after maintainer's requested update at Tue May 7 14:52:56 > 2002 UTC (Version 1.3 of port's Makefile) fails to build if previous > version is installed due to incompatibility with headers and early > inclusion of old header. > > Also, this port does not pay attention to $CFLAGS, unconditionally setting > them to '-g -O2', which is IIRC against ports policy. I have no patch for > this handy, though. > > Here is the quick fix for includes order (for -stable users, you can put > the in files/patch-xxxx). I suppose, all other Maikefile.in's should be > patched the same way. hi there. i came up with a better fix for the includes order problem yesterday and sent it off to roberto@freebsd.org, since he's the person who normally commits these things for me. well, it's the same fix, it just doesn't require all the patches. here's the patch for the makefile. (btw, this has already been fixed in the upstream sources.) thanks for letting me know about the CFLAGS problem. i will look into it as soon as i get the chance. -garrett Index: Makefile =================================================================== --- Makefile +++ tmp.37140.00001 Thu May 9 08:08:57 2002 @@ -25,6 +25,9 @@ ${SH} pkg-install apr-devel PRE-INSTALL pre-configure: + (find ${WRKDIR}/apr-util/ -name Makefile.in -exec \ + ${PERL} -pi -e 's/\@APRUTIL_INCLUDES\@ \@APRUTIL_PRIV_INCLUDES\@/\@APRUTIL_PRIV_INCLUDES\@ \@APRUTIL_INCLUDES\@/g' \{\} \;) + (cd ${WRKDIR}/apr/ && ./buildconf) (cd ${WRKDIR}/apr-util/ && ./buildconf) -- garrett rooney Remember, any design flaw you're rooneg@electricjellyfish.net sufficiently snide about becomes http://electricjellyfish.net/ a feature. -- Dan Sugalski To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-stable" in the body of the message