Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 29 Oct 2021 11:19:33 +0200
From:      Guido Falsi <madpilot@FreeBSD.org>
To:        ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org
Subject:   Re: git: 027ed04832c4 - main - deskutils/nextcloudclient: Fix build failure when tests are enabled
Message-ID:  <cb13d8ca-6944-3e91-22bd-8d1c5cba31d0@FreeBSD.org>
In-Reply-To: <202110290915.19T9FsiG028735@gitrepo.freebsd.org>
References:  <202110290915.19T9FsiG028735@gitrepo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On 29/10/21 11:15, Guido Falsi wrote:
> The branch main has been updated by madpilot:
> 
> URL: https://cgit.FreeBSD.org/ports/commit/?id=027ed04832c4160ac66139b8769a33d828ee7573
> 
> commit 027ed04832c4160ac66139b8769a33d828ee7573
> Author:     Guido Falsi <madpilot@FreeBSD.org>
> AuthorDate: 2021-10-29 09:13:03 +0000
> Commit:     Guido Falsi <madpilot@FreeBSD.org>
> CommitDate: 2021-10-29 09:13:03 +0000
> 
>      deskutils/nextcloudclient: Fix build failure when tests are enabled
>      
>      Upstream build system tries to include a Linux only library in the
>      build when tests are enabled.
>      
>      This patch has already been accepted upstream.
>      
>      PR:                     258119
>      Approved by:            Maintiner timeout
>      Obtained from:          https://github.com/nextcloud/desktop/pull/3880
> ---
>   deskutils/nextcloudclient/Makefile                            |  1 -
>   .../files/patch-test_nextcloud__add__test.cmake               | 11 +++++++++++
>   2 files changed, 11 insertions(+), 1 deletion(-)
> 
> diff --git a/deskutils/nextcloudclient/Makefile b/deskutils/nextcloudclient/Makefile
> index 57197c93ee57..7fd8e3ddd1c5 100644
> --- a/deskutils/nextcloudclient/Makefile
> +++ b/deskutils/nextcloudclient/Makefile
> @@ -29,7 +29,6 @@ CMAKE_ARGS=	-DBUILD_UPDATER:BOOL=OFF \
>   		-DWITH_STACK_PROTECTOR:BOOL=OFF
>   USE_LDCONFIG=	yes
>   
> -DEBUG=		yes
>   USE_GITHUB=	yes
>   GH_ACCOUNT=	nextcloud
>   GH_PROJECT=	desktop

Oops, I forgot to mention this, I also remove thiss spurious variable 
here, it's a nop.

-- 
Guido Falsi <madpilot@FreeBSD.org>



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?cb13d8ca-6944-3e91-22bd-8d1c5cba31d0>