From owner-svn-ports-head@freebsd.org Mon Aug 24 08:48:12 2015 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 86F4A9BFFFF; Mon, 24 Aug 2015 08:48:12 +0000 (UTC) (envelope-from baptiste.daroussin@gmail.com) Received: from mail-wi0-x232.google.com (mail-wi0-x232.google.com [IPv6:2a00:1450:400c:c05::232]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 1C953DE7; Mon, 24 Aug 2015 08:48:12 +0000 (UTC) (envelope-from baptiste.daroussin@gmail.com) Received: by wicja10 with SMTP id ja10so64859648wic.1; Mon, 24 Aug 2015 01:48:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=OumeI1I785cdFM0U2CEWilUBYBK6/PvQAI9kzi9lyBc=; b=dcP2MNm4lcebQAWN4aAZMm6q3uUtnDOeV5UTC6GfD3dD+Jy4UX3yhgOgaPpO9Jxe/k CkTRZyXHAAIYqd/J411JMONpNDEM0qDgFvJsNTSjYF/HWi29fmaS37U5IubyrwWCzkFl qDhBT+rbQFMKpfKkS67elJzjl8w8ywh85/P/41KfbQrsWCInon+c1eODMi5QwPtQWt1S 5apYdP7enAFN6pp6a6IQ8BnHsuKks/oHZ7e2UJqJ3l7/2SW9irM7oGeHMQHNRtgpx/nP tbq8xASBSPkpa2ukpPhhEl96aHF+UTfQoaRiFCj1k2YD52T+Y1e7ymsBusFjT3zCch35 vRAw== X-Received: by 10.194.190.110 with SMTP id gp14mr40582662wjc.76.1440406090558; Mon, 24 Aug 2015 01:48:10 -0700 (PDT) Received: from ivaldir.etoilebsd.net ([2001:41d0:8:db4c::1]) by smtp.gmail.com with ESMTPSA id i6sm22094869wje.33.2015.08.24.01.48.09 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 24 Aug 2015 01:48:09 -0700 (PDT) Sender: Baptiste Daroussin Date: Mon, 24 Aug 2015 10:48:07 +0200 From: Baptiste Daroussin To: Alexey Dokuchaev Cc: Mathieu Arnold , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r395079 - in head/graphics: . mitsuba mitsuba/files Message-ID: <20150824084807.GA93486@ivaldir.etoilebsd.net> References: <201508230856.t7N8uwal009338@repo.freebsd.org> <96D957F8044D8B647B259802@atuin.in.mat.cc> <20150824070915.GA15244@FreeBSD.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="cWoXeonUoKmBZSoM" Content-Disposition: inline In-Reply-To: <20150824070915.GA15244@FreeBSD.org> User-Agent: Mutt/1.5.23 (2014-03-12) X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 24 Aug 2015 08:48:12 -0000 --cWoXeonUoKmBZSoM Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Aug 24, 2015 at 07:09:15AM +0000, Alexey Dokuchaev wrote: > On Sun, Aug 23, 2015 at 11:43:21PM +0100, Mathieu Arnold wrote: > > +--On 23 ao??t 2015 08:56:58 +0000 Alexey Dokuchaev > > wrote: > > | +# Unfortunately, the code is not GCC 4.2.1 compatible (due to bugs i= n GCC > > | +# itself). Try to use system compiler if it is Clang, otherwise fal= lback > > | +# to modern GCC (on older versions of FreeBSD). > > | +.if ${OSVERSION} < 900014 > > | +USE_GCC=3D yes > >=20 > > OSVERSION < 900014 will always be false. Please, don't add more checks= on > > unsupported versions. >=20 > The fact that 8.X had reached its EOL merely means we cannot promise that > things won't break. It does not mean we should immediately pull the plug > and remove two lines from the Makefile, leaving 8.4 users with a broken > port. >=20 > It's up to maintainers to decide whether it's worth supporting some old > FreeBSD version. Keeping around intricate patches and having to rebase > and test on every update is a nuisance, so those patches probably deserve > to rest in attic now. Two lines in the Makefile are hardly a burden. >=20 > I typically would try to support as many FreeBSD versions as long the > port stays manageable. Often it's not a problem, and is very polite to > our users that do not want to upgrade for some reason (e.g. me and my > laptop are happy with stable/8 and see no reason to update, as it will > likely pessimize work experience without bringing any benefits over 8.4). >=20 > That said, OSVERSION < 900014 will not always be false. And why do you > want to be rude to our users and deliberately break things just because > we no longer promise that they will work? >=20 Even in that case, this is wrong anyway as you enforce GCC while should sho= uld require a modern compiler via compiler.mk. regards, Bapt --cWoXeonUoKmBZSoM Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlXa2kcACgkQ8kTtMUmk6Ew78gCgu2yb0K6Ylw41nLKRkxXB/aUM C0cAoLkvWWgzAt3fQRIFSAMahhGzXkWM =0cwj -----END PGP SIGNATURE----- --cWoXeonUoKmBZSoM--