From owner-freebsd-acpi@FreeBSD.ORG Thu Mar 10 21:03:30 2005 Return-Path: Delivered-To: freebsd-acpi@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D806216A4CE for ; Thu, 10 Mar 2005 21:03:30 +0000 (GMT) Received: from anuket.mj.niksun.com (gwnew.niksun.com [65.115.46.162]) by mx1.FreeBSD.org (Postfix) with ESMTP id 52BD743D58 for ; Thu, 10 Mar 2005 21:03:30 +0000 (GMT) (envelope-from jkim@niksun.com) Received: from [10.70.0.244] (daemon.mj.niksun.com [10.70.0.244]) by anuket.mj.niksun.com (8.13.1/8.12.11) with ESMTP id j2AL3TpB027825; Thu, 10 Mar 2005 16:03:29 -0500 (EST) (envelope-from jkim@niksun.com) From: Jung-uk Kim Organization: Niksun, Inc. To: Bruno Ducrot Date: Thu, 10 Mar 2005 16:03:26 -0500 User-Agent: KMail/1.6.2 References: <20050310171025.GB2298@poupinou.org> <4230AF39.4090100@root.org> In-Reply-To: <4230AF39.4090100@root.org> MIME-Version: 1.0 Content-Disposition: inline Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <200503101603.26659.jkim@niksun.com> X-Virus-Scanned: ClamAV 0.83/760/Wed Mar 9 12:12:01 2005 on anuket.mj.niksun.com X-Virus-Status: Clean cc: freebsd-acpi@freebsd.org Subject: Re: [cpufreq] powernow drivers X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Mar 2005 21:03:31 -0000 On Thursday 10 March 2005 03:34 pm, Nate Lawson wrote: > Bruno Ducrot wrote: > > The powernow stuff is nearly complete but need testings and more > > cleanup, especially the 2 drivers shoud be merged. > > I'm providing them right now at > > http://www.poupinou.org/cpufreq/bsd/powernow.tar.gz > > before the merge because I maybe offline for one or two weeks in > > a few days. > > > > The powernow k6 is not finished, but mainly because I dont have > > the hardware. It would be fine though that I know for sure that > > someone test it before I make it public, so if you have a cyrix > > K6/II or III with powernow! capability and you want to test > > please write me. > > Excellent, your work looks really nice. Just a few comments: > > Please remove my name from the copyright. You did all the work and > I just provided suggestions. You can remove mine too. This driver doesn't look like acpi_cnq at all. ;-) > Both drivers should just add a child called "powernow" instead of > k*_powernow. You can't have k7 and k8 powernow on the same system, > right? They can announce what hardware they are via > device_set_desc() which it appears you're already doing. Also, > DRIVER_MODULE for them should not have "pn8" as the first arg. > > You can remove the check for a freq >= 0xffff. I committed this to > acpi_perf already. > > Have you tested the ACPI attachment for this? Does it work ok? > I'm just curious because I don't have hw to test acpi-assisted > probing. I have and it works. > It looks like these can be merged pretty easily. Once you've done > that, I'd like to import this driver. > > Thanks very much, Thank you, both of you, Jung-uk Kim > -- > Nate