From owner-svn-src-all@FreeBSD.ORG Mon Nov 15 03:03:41 2010 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 45C3A1065696; Mon, 15 Nov 2010 03:03:41 +0000 (UTC) (envelope-from brde@optusnet.com.au) Received: from mail07.syd.optusnet.com.au (mail07.syd.optusnet.com.au [211.29.132.188]) by mx1.freebsd.org (Postfix) with ESMTP id B9ADA8FC1D; Mon, 15 Nov 2010 03:03:40 +0000 (UTC) Received: from c122-106-146-145.carlnfd1.nsw.optusnet.com.au (c122-106-146-145.carlnfd1.nsw.optusnet.com.au [122.106.146.145]) by mail07.syd.optusnet.com.au (8.13.1/8.13.1) with ESMTP id oAF33aCt007174 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 15 Nov 2010 14:03:37 +1100 Date: Mon, 15 Nov 2010 14:03:36 +1100 (EST) From: Bruce Evans X-X-Sender: bde@besplex.bde.org To: Bruce Cran In-Reply-To: <201011140609.oAE69oqd072190@svn.freebsd.org> Message-ID: <20101115135506.J1683@besplex.bde.org> References: <201011140609.oAE69oqd072190@svn.freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r215281 - head/sys/kern X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Nov 2010 03:03:41 -0000 On Sun, 14 Nov 2010, Bruce Cran wrote: > Log: > Add some descriptions to sys/kern sysctls. > Modified: head/sys/kern/kern_tc.c > ============================================================================== > --- head/sys/kern/kern_tc.c Sun Nov 14 05:05:41 2010 (r215280) > +++ head/sys/kern/kern_tc.c Sun Nov 14 06:09:50 2010 (r215281) > @@ -103,7 +103,7 @@ SYSCTL_NODE(_kern_timecounter, OID_AUTO, > > static int timestepwarnings; > SYSCTL_INT(_kern_timecounter, OID_AUTO, stepwarnings, CTLFLAG_RW, > - ×tepwarnings, 0, ""); > + ×tepwarnings, 0, "Log time steps"); Another problem (other than style bugs) with these and some old descriptions is inconsistent descriptions of boolean variables. I like always starting with "Enable". > @@ -768,7 +768,7 @@ pps_event(struct pps_state *pps, int eve > */ > > static int tc_tick; > -SYSCTL_INT(_kern_timecounter, OID_AUTO, tick, CTLFLAG_RD, &tc_tick, 0, ""); > +SYSCTL_INT(_kern_timecounter, OID_AUTO, tick, CTLFLAG_RD, &tc_tick, 0, "Approximate number of hardclock ticks in a millisecond"); It can't possibly be that if a hardclock tick is much larger than a millisecond, and this doesn't describe its purpose. It is actually a rate limiter for timecounter updates, to avoid the natural rate of once per hardclock tick if that is considered too frequent. Thus it has nothing to do with milliseconds except once per millisecond is considered frequent enough. It is the number of hardclock ticks between timercounter updates. Bruce