Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 22 Nov 2005 16:08:19 GMT
From:      "Scot W. Hetzel" <swhetzel@gmail.com>
To:        freebsd-gnats-submit@FreeBSD.org
Subject:   misc/89423: The example make.conf has tabs before the comment deliminator (#).
Message-ID:  <200511221608.jAMG8J7r096290@www.freebsd.org>
Resent-Message-ID: <200511221610.jAMGASV0060404@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         89423
>Category:       misc
>Synopsis:       The example make.conf has tabs before the comment deliminator (#).
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Nov 22 16:10:28 GMT 2005
>Closed-Date:
>Last-Modified:
>Originator:     Scot W. Hetzel
>Release:        FreeBSD 7.x-CURRENT
>Organization:
>Environment:
>Description:
Two additional comments were added for the NO_NIS variable in src/share/examples/etc/make.conf.  The author of these changes placed two tabs before the comment deliminator(#).  When this file is copied to /etc/make.conf, it causes make to report that it can't execute "# If set, you might need to adopt your" and "# nsswitch.conf(5) and remove `nis' entries."  Make expects the comment deliminator to be in the first column.

I know that some are going to say don't copy the file to /etc/make.conf, but at the top of the file it says:

# This file must be in valid Makefile syntax.

placing two tabs before the comment deliminator is not valid Makefile syntax.

>How-To-Repeat:
copy src/share/examples/etc/make.conf to /etc/make.conf
then try a buildworld
>Fix:
Index: make.conf
===================================================================
RCS file: /home/ncvs/src/share/examples/etc/make.conf,v
retrieving revision 1.269
diff -u -r1.269 make.conf
--- make.conf	23 Oct 2005 19:37:55 -0000	1.269
+++ make.conf	22 Nov 2005 07:41:35 -0000
@@ -125,8 +125,8 @@
 #NO_MODULES=		# do not build modules with the kernel
 #NO_NETCAT=		# do not build netcat
 #NO_NIS=		# do not build NIS support and related programs.
-			# If set, you might need to adopt your
-			# nsswitch.conf(5) and remove `nis' entries.
+#			# If set, you might need to adopt your
+#			# nsswitch.conf(5) and remove `nis' entries.
 #NO_OBJC=		# do not build Objective C support
 #NO_OPENSSH=		# do not build OpenSSH
 #NO_OPENSSL=		# do not build OpenSSL (implies NO_KERBEROS/NO_OPENSSH)

>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200511221608.jAMG8J7r096290>