From owner-cvs-src@FreeBSD.ORG Thu Jun 22 03:11:18 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 955D116A474; Thu, 22 Jun 2006 03:11:18 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from fw.zoral.com.ua (ll-227.216.82.212.sovam.net.ua [212.82.216.227]) by mx1.FreeBSD.org (Postfix) with ESMTP id D20D743D48; Thu, 22 Jun 2006 03:11:17 +0000 (GMT) (envelope-from kostikbel@gmail.com) Received: from deviant.kiev.zoral.com.ua (root@deviant.kiev.zoral.com.ua [10.1.1.148]) by fw.zoral.com.ua (8.13.4/8.13.4) with ESMTP id k5M3BCTS073005 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 22 Jun 2006 06:11:12 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1]) by deviant.kiev.zoral.com.ua (8.13.6/8.13.6) with ESMTP id k5M3BBPZ017418; Thu, 22 Jun 2006 06:11:11 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by deviant.kiev.zoral.com.ua (8.13.6/8.13.6/Submit) id k5M3BBUk017417; Thu, 22 Jun 2006 06:11:11 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to kostikbel@gmail.com using -f Date: Thu, 22 Jun 2006 06:11:11 +0300 From: Kostik Belousov To: John Baldwin Message-ID: <20060622031111.GA5115@deviant.kiev.zoral.com.ua> References: <200606212103.k5LL3OsA040402@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="k+w/mQv8wyuph6w0" Content-Disposition: inline In-Reply-To: <200606212103.k5LL3OsA040402@repoman.freebsd.org> User-Agent: Mutt/1.4.2.1i X-Virus-Scanned: ClamAV version 0.88.2, clamav-milter version 0.88.2 on fw.zoral.com.ua X-Virus-Status: Clean X-Spam-Status: No, score=-0.1 required=5.0 tests=ALL_TRUSTED,SPF_NEUTRAL autolearn=failed version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on fw.zoral.com.ua Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/pci if_dc.c if_dcreg.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Jun 2006 03:11:18 -0000 --k+w/mQv8wyuph6w0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jun 21, 2006 at 09:03:24PM +0000, John Baldwin wrote: > jhb 2006-06-21 21:03:24 UTC >=20 > FreeBSD src repository >=20 > Modified files: (Branch: RELENG_6) > sys/pci if_dc.c if_dcreg.h=20 > Log: > MFC various cleanups: > - Switch on the full 32-bit device ID to avoid collisions between the > vendor-specific device ids across vendors. > - Include the revision in the dc_devs[] array instead of special casing > the revid handling in dc_devtype(). > - Use PCI bus accessors to read registers instead of pci_read_config() > where possible. > - Use an 8-bit write to update the latency timer. > - Use PCIR_xxx constants and remove unused DC_xxx related to standard > PCI config registers. It seems that file sys/dev/mii/dcphy.c references removed constant from the if_dcreg.h. That file was removed itself from the CURRENT by imp several month ago. But it is still alive on RELENG_6. With the MFC, I got buildkernel errors: cc -O2 -fno-strict-aliasing -pipe -march=3Dpentiumpro -Werror -D_KERNEL -DK= LD_MODULE -nostdinc -I- -DHAVE_KERNEL_OPTION_HEADERS -include /usr/bsd/ob= j/usr/bsd/src/sys/POOMA/opt_global.h -I. -I@ -I@/contrib/altq -I@/../includ= e -finline-limit=3D8000 -fno-common -g -I/usr/bsd/obj/usr/bsd/src/sys/POOMA= -mno-align-long-strings-mpreferred-stack-boundary=3D2 -mno-mmx -mno-3dnow= -mno-sse -mno-sse2 -ffreestanding -Wall -Wredundant-decls -Wnested-externs= -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-= qual -fformat-extensions -std=3Dc99 -c /usr/bsd/src/sys/modules/mii/../../= dev/mii/dcphy.c /usr/bsd/src/sys/modules/mii/../../dev/mii/dcphy.c: In function `dcphy_atta= ch': /usr/bsd/src/sys/modules/mii/../../dev/mii/dcphy.c:172: error: `DC_PCI_CSID= ' undeclared (first use in this function) /usr/bsd/src/sys/modules/mii/../../dev/mii/dcphy.c:172: error: (Each undecl= ared identifier is reported only once /usr/bsd/src/sys/modules/mii/../../dev/mii/dcphy.c:172: error: for each fun= ction it appears in.) *** Error code 1 Stop in /usr/bsd/src/sys/modules/mii. --k+w/mQv8wyuph6w0 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.3 (FreeBSD) iD8DBQFEmgpOC3+MBN1Mb4gRAodWAKCsNRJNTMkARJhOMvWkU+dOEw5bdQCeO8El 5y1v55/vuj8v6pmo+Q6//bk= =8TOX -----END PGP SIGNATURE----- --k+w/mQv8wyuph6w0--