From owner-cvs-src@FreeBSD.ORG Thu Oct 25 19:48:53 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7328616A418; Thu, 25 Oct 2007 19:48:53 +0000 (UTC) (envelope-from eischen@vigrid.com) Received: from mail.netplex.net (mail.netplex.net [204.213.176.10]) by mx1.freebsd.org (Postfix) with ESMTP id 5A10813C4A6; Thu, 25 Oct 2007 19:48:52 +0000 (UTC) (envelope-from eischen@vigrid.com) Received: from sea.ntplx.net (sea.ntplx.net [204.213.176.11]) by mail.netplex.net (8.14.1/8.14.1/NETPLEX) with ESMTP id l9PJVKkt002702; Thu, 25 Oct 2007 15:31:20 -0400 (EDT) X-Virus-Scanned: by AMaViS and Clam AntiVirus (mail.netplex.net) X-Greylist: Message whitelisted by DRAC access database, not delayed by milter-greylist-3.0 (mail.netplex.net [204.213.176.10]); Thu, 25 Oct 2007 15:31:21 -0400 (EDT) Date: Thu, 25 Oct 2007 15:31:20 -0400 (EDT) From: Daniel Eischen X-X-Sender: eischen@sea.ntplx.net To: Andrey Chernov In-Reply-To: <20071025192501.GG16187@nagual.pp.ru> Message-ID: References: <200710150951.l9F9pUm7026506@repoman.freebsd.org> <4720B30F.4040903@samsco.org> <20071025151707.GA11398@nagual.pp.ru> <4720C7D6.9090004@delphij.net> <20071025190019.GA16187@nagual.pp.ru> <4720E9E1.7000900@delphij.net> <20071025192501.GG16187@nagual.pp.ru> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: cvs-src@FreeBSD.org, Scott Long , src-committers@FreeBSD.org, d@delphij.net, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/libc/locale utf8.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Oct 2007 19:48:53 -0000 On Thu, 25 Oct 2007, Andrey Chernov wrote: > On Thu, Oct 25, 2007 at 03:17:32PM -0400, Daniel Eischen wrote: >> Why not simply avoid the error check for inlines. Solaris >> doesn't seem to add a check, it just does the conversion. >> The non-inlined versions do error checking. > > Although standard permit this, it will cause lots of programs to break > here and there and even may cause core dump. I don't think it is what > everybody wants. Non-inlined versions a) not used nowdays b) must be exact > as inlined. If programs are incorrectly written, and they use inlines, then that is not our fault :-) The problem with trying to do error checking and other esoteric things with inlines is that it exposes our private parts to the world. You can get arrested for that ;-) How much juice are we really trying to squeeze out of these inlines anyway? -- DE