Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 20 Apr 2009 23:25:38 +0000 (UTC)
From:      Robert Watson <rwatson@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r191343 - head/sys/net
Message-ID:  <200904202325.n3KNPcq1061268@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: rwatson
Date: Mon Apr 20 23:25:38 2009
New Revision: 191343
URL: http://svn.freebsd.org/changeset/base/191343

Log:
  Acquire interfce address list lock while walking the interface address
  list during tun device initialization.
  
  MFC after:	2 weeks

Modified:
  head/sys/net/if_tun.c

Modified: head/sys/net/if_tun.c
==============================================================================
--- head/sys/net/if_tun.c	Mon Apr 20 23:23:31 2009	(r191342)
+++ head/sys/net/if_tun.c	Mon Apr 20 23:25:38 2009	(r191343)
@@ -520,6 +520,7 @@ tuninit(struct ifnet *ifp)
 	getmicrotime(&ifp->if_lastchange);
 
 #ifdef INET
+	IF_ADDR_LOCK(ifp);
 	TAILQ_FOREACH(ifa, &ifp->if_addrhead, ifa_link) {
 		if (ifa->ifa_addr->sa_family == AF_INET) {
 			struct sockaddr_in *si;
@@ -535,6 +536,7 @@ tuninit(struct ifnet *ifp)
 			mtx_unlock(&tp->tun_mtx);
 		}
 	}
+	IF_ADDR_UNLOCK(ifp);
 #endif
 	return (error);
 }



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200904202325.n3KNPcq1061268>