From owner-freebsd-java@FreeBSD.ORG Sun Apr 3 14:55:27 2005 Return-Path: Delivered-To: freebsd-java@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1049916A4CE for ; Sun, 3 Apr 2005 14:55:27 +0000 (GMT) Received: from outmx012.isp.belgacom.be (outmx012.isp.belgacom.be [195.238.3.70]) by mx1.FreeBSD.org (Postfix) with ESMTP id 06F1543D1F for ; Sun, 3 Apr 2005 14:55:26 +0000 (GMT) (envelope-from brvdboss@spymac.com) Received: from outmx012.isp.belgacom.be (localhost [127.0.0.1]) with ESMTP id j33EtL8A008612 for ; Sun, 3 Apr 2005 16:55:21 +0200 (envelope-from ) Received: from [10.0.0.42] (138.234-201-80.adsl.skynet.be [80.201.234.138]) with ESMTP id j33EtJq4008594 for ; Sun, 3 Apr 2005 16:55:20 +0200 (envelope-from ) Message-ID: <425003E5.9020905@spymac.com> Date: Sun, 03 Apr 2005 16:55:33 +0200 From: Bruno Van Den Bossche Organization: Me, Myself & I User-Agent: Mozilla Thunderbird 1.0.2 (X11/20050328) X-Accept-Language: en-us, en MIME-Version: 1.0 To: freebsd-java@freebsd.org References: <424490CD.9080203@chuckr.org> <4246D3C5.5060303@ebs.gr> <4246FE33.2090608@webct.com> <4248801D.7070405@webct.com> <42489BD2.40504@varju.ca> <424BA422.8070803@varju.ca> <424C5C2A.9080407@spymac.com> <424CBA64.4040404@varju.ca> <424DD0FA.1070003@spymac.com> <424F34F4.4030709@varju.ca> In-Reply-To: <424F34F4.4030709@varju.ca> Content-Type: multipart/mixed; boundary="------------000306000002070109060806" Subject: Re: eclipse X-BeenThere: freebsd-java@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: brvdboss@spymac.com List-Id: Porting Java to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 03 Apr 2005 14:55:27 -0000 This is a multi-part message in MIME format. --------------000306000002070109060806 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 8bit Alex Varju wrote: > Bruno Van Den Bossche wrote: > >>> Until Eclipse supports native 1.5 builds, I'm not sure that there's >>> anything we can do to improve things. >> >> >> I've been staring a bit at it but can't really come up with a >> solution. The naïve me assumed the specified "target" and "source" >> options would be taking care of issues like that. > > > 3.1m6 is out, and the release notes seem to indicate that their compiler > is now Java 1.5 compliant. Unfortunately, I get different errors (which > sound likely to be the same thing) if I try to remove the linux-jdk > requirement. > > Hopefully by the time 3.1 is actually released, they will have worked > these problems out. I found the problem, at least I like to think so :) In the file plugins/org.eclipse.ui.browser/src/org/eclipse/ui/internal/browser/ExternalBrowserInstance.java they make the following call : DefaultBrowserSupport.getInstance().removeBrowser(getId()); This method requires a String for argument, and getId() returns a long. Which is a conversion that doesn't automagically happens. Changing this to : DefaultBrowserSupport.getInstance().removeBrowser(""+getId()); solves this problem and everything builds just fine on my machine without the need of a linux-jvm. This is an Eclipse-issue though. You seem to be more familiar with the Eclipse project, could you submit this to them? > My new patchset for 3.1m6 is here: > > http://www.varju.ca/alex/freebsd/eclipse-devel-3.1m6-1.tgz I've attached the patch for this dir. It should allow you to build the port now without the need for the linux-libraries. I hope you can confirm this :-) Regards, Bruno PS: Teaser ;-) : ... [exec] a eclipse/notice.html [exec] a eclipse/eclipse.ini [exec] a eclipse/epl-v10.html [echo] Done. BUILD SUCCESSFUL Total time: 7 minutes 39 seconds wave# --------------000306000002070109060806 Content-Type: text/plain; name="patch.diff" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="patch.diff" diff -rNu eclipse-devel.orig/files/patch-build.xml /usr/ports/java/eclipse-devel/files/patch-build.xml --- eclipse-devel.orig/files/patch-build.xml Sun Apr 3 01:22:50 2005 +++ eclipse-devel/files/patch-build.xml Sun Apr 3 16:39:36 2005 @@ -35,15 +35,6 @@ -@@ -148,7 +156,7 @@ - - - -- -+ - - - @@ -193,6 +201,9 @@ diff -rNu eclipse-devel.orig/files/patch-source-ExternalBrowser /usr/ports/java/eclipse-devel/files/patch-source-ExternalBrowser --- eclipse-devel.orig/files/patch-source-ExternalBrowser Thu Jan 1 01:00:00 1970 +++ eclipse-devel/files/patch-source-ExternalBrowser Sun Apr 3 16:03:55 2005 @@ -0,0 +1,13 @@ +--- plugins/org.eclipse.ui.browser/src/org/eclipse/ui/internal/browser/ExternalBrowserInstance.java.orig Sun Apr 3 15:44:23 2005 ++++ plugins/org.eclipse.ui.browser/src/org/eclipse/ui/internal/browser/ExternalBrowserInstance.java Sun Apr 3 15:44:47 2005 + +@@ -74,7 +74,7 @@ + public void run() { + try { + process.waitFor(); +- DefaultBrowserSupport.getInstance().removeBrowser(getId()); ++ DefaultBrowserSupport.getInstance().removeBrowser(""+getId()); + } catch (Exception e) { + // ignore + } + --------------000306000002070109060806--