From owner-cvs-all  Wed Feb 21  4:26: 5 2001
Delivered-To: cvs-all@freebsd.org
Received: from freesbee.wheel.dk (freesbee.wheel.dk [193.162.159.97])
	by hub.freebsd.org (Postfix) with ESMTP
	id A38DB37B491; Wed, 21 Feb 2001 04:25:52 -0800 (PST)
	(envelope-from jesper@skriver.dk)
Received: by freesbee.wheel.dk (Postfix, from userid 1001)
	id 501353E68; Wed, 21 Feb 2001 13:25:51 +0100 (CET)
Date: Wed, 21 Feb 2001 13:25:51 +0100
From: Jesper Skriver <jesper@skriver.dk>
To: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/netinet ip_input.c
Message-ID: <20010221132551.B69412@skriver.dk>
References: <200102202131.f1KLVmD90813@freefall.freebsd.org> <20010221105306.D32098@sunbay.com> <20010221103925.G93678@skriver.dk> <20010221114143.G12746@ringworld.oblivion.bg>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2.5i
In-Reply-To: <20010221114143.G12746@ringworld.oblivion.bg>; from roam@orbitel.bg on Wed, Feb 21, 2001 at 11:41:43AM +0200
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG

On Wed, Feb 21, 2001 at 11:41:43AM +0200, Peter Pentchev wrote:
> On Wed, Feb 21, 2001 at 10:39:25AM +0100, Jesper Skriver wrote:
> > On Wed, Feb 21, 2001 at 10:53:06AM +0200, Ruslan Ermilov wrote:
> > > On Tue, Feb 20, 2001 at 01:31:48PM -0800, Jesper Skriver wrote:
> > > > jesper      2001/02/20 13:31:48 PST
> > > > 
> > > >   Modified files:
> > > >     sys/netinet          ip_input.c 
> > > >   Log:
> > > >   Send a ICMP unreachable instead of dropping the packet silent, if we
> > > >   receive a packet not for us, and forwarding disabled.
> > > >   
> > > >   PR:		kern/24512
> > > >   Reviewed by:	jlemon
> > > >   Approved by:	jlemon
> > >
> > > This violates Host Requirements RFC 1122.  In section 3.2.1.3, we read:
> > 
> > Oups, what about - even if it violates the rfc, it's quite usefull in
> > some corner cases - it's something we use locally here, so I suggest
> > leaving it in, but disabled by default, and with the warning, ok ?
> 
> just a minor nit..
> 
> [snip]
> > -	0, "Send ICMP unreach when packet not for us rx, and forwarding disabled");
> > +	0, "Send ICMP unreach when packet not for us rx, and forwarding disabled, note violate rfc1122 section 3.2.1.3");
> 
> "..note that this violates.."
> 
> > +		 *
> > +		 * Note: violate rfc1122 section 3.2.1.3, therefor disabled
> > +		 *       by default.
> 
> "Note: this violates .. therefore it is disabled.."

Thanks - english spelling and grammar is not my strong point ...

/Jesper

-- 
Jesper Skriver, jesper(at)skriver(dot)dk  -  CCIE #5456
Work:    Network manager   @ AS3292 (Tele Danmark DataNetworks)
Private: FreeBSD committer @ AS2109 (A much smaller network ;-)

One Unix to rule them all, One Resolver to find them,
One IP to bring them all and in the zone to bind them.

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message