Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 4 Aug 2006 11:03:05 -0400
From:      John Baldwin <jhb@freebsd.org>
To:        Yar Tikhiy <yar@comp.chem.msu.su>
Cc:        cvs-src@freebsd.org, Stefan Farfeleder <stefanf@freebsd.org>, pdeuskar@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org
Subject:   Re: cvs commit: src/sys/dev/em if_em.c if_em.h
Message-ID:  <200608041103.06045.jhb@freebsd.org>
In-Reply-To: <20060804074657.GT97316@comp.chem.msu.su>
References:  <200608031905.k73J55D2061870@repoman.freebsd.org> <20060804072323.GC89735@wombat.fafoe.narf.at> <20060804074657.GT97316@comp.chem.msu.su>

next in thread | previous in thread | raw e-mail | index | archive | help
On Friday 04 August 2006 03:46, Yar Tikhiy wrote:
> On Fri, Aug 04, 2006 at 09:23:23AM +0200, Stefan Farfeleder wrote:
> > On Fri, Aug 04, 2006 at 11:19:09AM +0400, Yar Tikhiy wrote:
> > > 
> > > As a general remark, it is a very good idea to keep large style(9)
> > > sweeps separate from actual code changes even if they are tiny.
> > > Changing style(9) shouldn't alter the binary code produced, and
> > > this can be 100% verified using cmp(1), diff(1), cksum(1), or md5(1).
> > > Of course, changing line numbers will affect debug info, but the
> > > latter can be strip(1)'ed.  In the case under discussion, I'd compare
> > > if_em.o with its former version to make sure no code changed.
> > 
> > It will produce different code if __LINE__ is used.
> 
> Yeah, it's a thing to watch out for.  As are __TIME__ and __DATE__.
> Fortunately, they are not widely used in src/, AFAIK.

If you have INVARIANTS on then every mtx_lock/unlock will include __LINE__ and 
__FILE__.

-- 
John Baldwin



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200608041103.06045.jhb>