From owner-svn-src-head@FreeBSD.ORG Mon Dec 1 19:27:55 2014 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 6DCE0F7B for ; Mon, 1 Dec 2014 19:27:55 +0000 (UTC) Received: from mail-wg0-f44.google.com (mail-wg0-f44.google.com [74.125.82.44]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id EC312BC2 for ; Mon, 1 Dec 2014 19:27:54 +0000 (UTC) Received: by mail-wg0-f44.google.com with SMTP id b13so15256305wgh.31 for ; Mon, 01 Dec 2014 11:27:53 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:message-id:date:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=Bg1zyZzWrDc0YkyHQDF/Eyi0ca/gtUAG+3Uz0ND19VE=; b=ZtSK6Q/CLsxUJsOuKAUF9Xa8jCZexpnlqfLtKtp+RIcJhUhThxbzjLFbB8AgkEAoPm 3Ubr10jYL3blpY7GQM6Kr7/lv2jY+L92ks5qtBKbzyfASV2y6I91hzNLzZJLEsEUB+b+ SD2r/6oVdZkKkCXBHsoDrsbggiqUGtGZ/ePNItrb6uF4BUu/rY8nwpyi0Q8SLpaP44Zc +ZU9cNzoNCUvPi1KmxSx87YLsMZPbxdqCbFZo+P2JUrTuN/3K/DRwyecDr8/srcjZvWD 2TacG5XYZyhf3HpDRURqjmfs5eGOIhURLfBO9oG0lx27O5YKjfsIfuD7L9Yh63mmuk8r /gRQ== X-Gm-Message-State: ALoCoQkw8XBtKDPlZ9jXvuszNv2eQCYiO2ixJNG29eNbzk2ONapEvmCGzeLGNkwQoIL3bPLte0Jw X-Received: by 10.180.73.143 with SMTP id l15mr85824634wiv.24.1417462073016; Mon, 01 Dec 2014 11:27:53 -0800 (PST) Received: from [10.10.1.68] (82-69-141-170.dsl.in-addr.zen.co.uk. [82.69.141.170]) by mx.google.com with ESMTPSA id qg11sm22841639wic.17.2014.12.01.11.27.51 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 01 Dec 2014 11:27:52 -0800 (PST) From: Steven Hartland X-Google-Original-From: Steven Hartland Message-ID: <547CC1B5.3070801@freebsd.org> Date: Mon, 01 Dec 2014 19:29:57 +0000 User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Jack Vogel Subject: Re: svn commit: r275136 - in head/sys: dev/e1000 dev/ixgbe kern sys References: <201411262019.sAQKJaw4043557@svn.freebsd.org> <39377603.10OyiSzjWY@ralph.baldwin.cx> <872C180A-6ADD-469F-A801-3728DF134EEC@mu.org> <547C88A9.1070007@selasky.org> <5E1B6CD4-BBA7-4AD0-9982-E981015AF138@mu.org> <547C8A9C.4080603@selasky.org> <547C8CA2.8040305@selasky.org> <547C8DEF.5020809@selasky.org> <547C974A.9050302@selasky.org> <4CE4C10D-93B0-4E27-878D-34C0A7CF3C94@mu.org> <547C995A.2060005@selasky.org> <547CBBC9.2070408@freebsd.org> In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: Hans Petter Selasky , Alfred Perlstein , John Baldwin , "svn-src-all@freebsd.org" , Alfred Perlstein , "src-committers@freebsd.org" , "svn-src-head@freebsd.org" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Dec 2014 19:27:55 -0000 On 01/12/2014 19:17, Jack Vogel wrote: > Not taking it personally, in this case I see some style things I don't > like, and I'm not at all clear > why this is even necessary, what the old way of doing queue config was > missing for instance? Having asked the same question on the review I think I can take a stab at answering that question; they are looking to tune the number of queues on a NIC by NIC basis based on the available CPU cores via an external module. For reference the original review can be found here: https://reviews.freebsd.org/D1149 Regards Steve