From owner-freebsd-current@FreeBSD.ORG Sun Apr 5 17:37:41 2015 Return-Path: Delivered-To: current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 09D8D1C5; Sun, 5 Apr 2015 17:37:41 +0000 (UTC) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 887C7687; Sun, 5 Apr 2015 17:37:40 +0000 (UTC) Received: from tom.home (kostik@localhost [127.0.0.1]) by kib.kiev.ua (8.14.9/8.14.9) with ESMTP id t35HbNZ9034609 (version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO); Sun, 5 Apr 2015 20:37:23 +0300 (EEST) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.9.2 kib.kiev.ua t35HbNZ9034609 Received: (from kostik@localhost) by tom.home (8.14.9/8.14.9/Submit) id t35HbNgJ034608; Sun, 5 Apr 2015 20:37:23 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Sun, 5 Apr 2015 20:37:23 +0300 From: Konstantin Belousov To: Gleb Smirnoff Subject: Re: panic: Lock vm object not exclusively locked @ /usr/src/sys/vm/vm_page.c:2637 Message-ID: <20150405173723.GR2379@kib.kiev.ua> References: <20150405133758.GA40261@albert.catwhisker.org> <20150405154721.GO64665@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150405154721.GO64665@FreeBSD.org> User-Agent: Mutt/1.5.23 (2014-03-12) X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.0 X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on tom.home Cc: alc@FreeBSD.org, current@freebsd.org X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 05 Apr 2015 17:37:41 -0000 On Sun, Apr 05, 2015 at 06:47:21PM +0300, Gleb Smirnoff wrote: > This is r281079. > > Since vm_page_advise() may call vm_page_dirty() in the MADV_DONTNEED case, > the assertion is valid. So, looks like vm_fault_dontneed() needs W-lock on > the first_object. > Either this, or vm_page_advise() could be changed to do nothing in the case of MADV_DONTNEED operation and a need to call vm_page_dirty(), if the object is only read-locked.