From owner-freebsd-doc@FreeBSD.ORG Sun Apr 20 04:32:14 2003 Return-Path: Delivered-To: freebsd-doc@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DF7DF37B401; Sun, 20 Apr 2003 04:32:14 -0700 (PDT) Received: from arthur.nitro.dk (port324.ds1-khk.adsl.cybercity.dk [212.242.113.79]) by mx1.FreeBSD.org (Postfix) with ESMTP id CE01843FDF; Sun, 20 Apr 2003 04:32:13 -0700 (PDT) (envelope-from simon@arthur.nitro.dk) Received: by arthur.nitro.dk (Postfix, from userid 1000) id A0E5910BF82; Sun, 20 Apr 2003 13:32:11 +0200 (CEST) Date: Sun, 20 Apr 2003 13:32:11 +0200 From: "Simon L. Nielsen" To: Hiroki Sato Message-ID: <20030420113210.GA390@nitro.dk> References: <200304191540.h3JFeSxV052609@bmah.dyndns.org> <20030420.020436.102903006.hrs@eos.ocn.ne.jp> <200304191749.h3JHndxV053505@bmah.dyndns.org> <20030420.195205.50333554.hrs@eos.ocn.ne.jp> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="rwEMma7ioTxnRzrJ" Content-Disposition: inline In-Reply-To: <20030420.195205.50333554.hrs@eos.ocn.ne.jp> User-Agent: Mutt/1.5.4i cc: bmah@FreeBSD.org cc: doc@FreeBSD.org Subject: Re: suggestion for adding a l10n-capable doc-format navi X-BeenThere: freebsd-doc@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Documentation project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 20 Apr 2003 11:32:15 -0000 --rwEMma7ioTxnRzrJ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 2003.04.20 19:52:05 +0900, Hiroki Sato wrote: > How about the following: >=20 > 1) WITH_FOO is defined and WITH_FOO!=3DNO, it means YES. > 2) WITH_FOO is defined and WITH_FOO=3D=3DNO, it means NO. > 3) WITH_FOO is not defined, it means NO. Personally I think this is a bad idea since most other places in the FreeBSD makefiles it is only important if the variabel is set or not. > A problem of that defining of WITH_FOO always means YES is that > we cannot disable it if it is enabled by default in Makefile > using WITH_FOO?=3DYES. But as you pointed out, in other places > this sort of variables that is defined mean YES regardless of what > the value was. The above behavior is not against the old one, I think. The way the disabled case is handled some other places is by using a NO_FOO or NOFOO variable which then takes precedents over the WITH_FOO variable e.g. by : =2Eif defined(NO_FOO) =2Eundef WITH_FOO =2Eendif I know this seems more troublesome but IMHO it is preferable since it is more consitent with all the other FreeBSD makefiles. I think it would be more intuitive if setting a make variable to NO really disabled the variable in all the FreeBSD makefiles but since it doesn't I think it is more or less impossible to remember when using NO is ok and when it is not. I know this seems like a bike shed (and probably is a bit) but I think consitency is rather important. --=20 Simon L. Nielsen --rwEMma7ioTxnRzrJ Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (FreeBSD) iD8DBQE+ooU68kocFXgPTRwRAuSAAJsFtFPfT8xDOZWIhEI0xBluMlbTJACgu3OJ z3V0QuE7qPD9L91BjzJX1lo= =cULz -----END PGP SIGNATURE----- --rwEMma7ioTxnRzrJ--