From owner-freebsd-net@FreeBSD.ORG Tue Jun 9 14:10:14 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id E9D83444 for ; Tue, 9 Jun 2015 14:10:14 +0000 (UTC) (envelope-from csforgeron@gmail.com) Received: from mail-qk0-x22b.google.com (mail-qk0-x22b.google.com [IPv6:2607:f8b0:400d:c09::22b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id A52A918E6 for ; Tue, 9 Jun 2015 14:10:14 +0000 (UTC) (envelope-from csforgeron@gmail.com) Received: by qkx62 with SMTP id 62so9836942qkx.3 for ; Tue, 09 Jun 2015 07:10:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=XiQwR98sJIIHe7nDnhDPLInl4A6CeYIzHIRMUXo1E+g=; b=Ft0GbkFCaWzytKLMAg/bg5vvjTkevPGi3nmS8CmeL5L7irzssUavfkL7MqnCU2j8ys 3AwuZxoDeWyOcn1IhVB/WRPexaC/rQHqTC9fTthKEtKWneYIIWYZIxqhNl7n5LSldWs6 0ORkNk1Ch1kSWhovJYmPQDv9rOkwLVxcbqyfgp4c0X0gUyYiTqRdAGTdDtfsi171Kegg zyva6A6cIz5fIeEn8A1M6aIgzKyj8yLDYcrTyYlTsX6vt0XG43BMPHYAjj3KjWeiD7GC aWPczQdn69a8VyD4SvX2m7DC6ha8A07oebvy8DOulv5ccmbz7MN9WCTkaeKbpjer+En0 sZWw== MIME-Version: 1.0 X-Received: by 10.140.31.162 with SMTP id f31mr21092362qgf.23.1433859013763; Tue, 09 Jun 2015 07:10:13 -0700 (PDT) Received: by 10.96.18.202 with HTTP; Tue, 9 Jun 2015 07:10:13 -0700 (PDT) In-Reply-To: <597381612.53959816.1433803537015.JavaMail.root@uoguelph.ca> References: <597381612.53959816.1433803537015.JavaMail.root@uoguelph.ca> Date: Tue, 9 Jun 2015 11:10:13 -0300 Message-ID: Subject: Re: setting if_hw_tsomax{segcount, segsize} in net drivers From: Christopher Forgeron To: Rick Macklem Cc: freebsd-net Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.20 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Jun 2015 14:10:15 -0000 Thanks for keeping up on this Rick. TSO needs to be fixed on FreeBSD, but it does not seem to be a hot-button topic. I still suffer from TSO issues, and thus turn it off in a standard build - but I noticed that machines that were VMWare 5.1-6.0, running the vmx driver, they did not have problems if TSO was on. I dug into the source far enough to see that vmx doesn't look to allocate more than a 4k mbuf unlike ixgeb/others, but I didn't test/dig further. On Mon, Jun 8, 2015 at 7:45 PM, Rick Macklem wrote: > Hi, > > I just looked at stable/10 and found the following 4 drivers have > set the if_hw_tsomax, if_hw_tsomaxsegcount and if_hw_tsomaxsegsize > fields: > > ./xen/netfront/netfront.c > ./cxgbe/t4_main.c > ./oce/oce_if.c > ./vmware/vmxnet3/if_vmx.c > > If you are the author/maintainer for a network device driver that does > TSO and is not on the above list...please, please fill in the above > fields before the call to ether_ifattach(), so that TSO will hopefully > work correctly with NFS/iSCSI. (I said "hopefully" because there might > be other bugs related to TSO in your driver that I wouldn't know about.) > > Maybe someone could mention this at BSDCan too? > > Thanks in advance for doing this, rick > ps: I would be really nice to get this done for 10.2 imho. > _______________________________________________ > freebsd-net@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-net > To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org" >