From owner-freebsd-current@FreeBSD.ORG Wed May 31 23:40:26 2006 Return-Path: X-Original-To: current@FreeBSD.org Delivered-To: freebsd-current@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 06A0016AFB9 for ; Wed, 31 May 2006 23:40:26 +0000 (UTC) (envelope-from marcus@FreeBSD.org) Received: from creme-brulee.marcuscom.com (creme-brulee.marcuscom.com [24.172.16.118]) by mx1.FreeBSD.org (Postfix) with ESMTP id 35D5B43D69 for ; Wed, 31 May 2006 23:40:22 +0000 (GMT) (envelope-from marcus@FreeBSD.org) Received: from shumai.marcuscom.com (shumai.marcuscom.com [192.168.1.4]) by creme-brulee.marcuscom.com (8.13.6/8.13.6) with ESMTP id k4VNeCYR096559; Wed, 31 May 2006 19:40:12 -0400 (EDT) (envelope-from marcus@FreeBSD.org) From: Joe Marcus Clarke To: Craig Rodrigues In-Reply-To: <20060531154439.GA5528@crodrigues.org> References: <1148962081.8820.49.camel@shumai.marcuscom.com> <20060530160405.GA39658@crodrigues.org> <1149006607.94908.5.camel@shumai.marcuscom.com> <20060531154439.GA5528@crodrigues.org> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-+drc+/V6v6nzgn89KlER" Organization: FreeBSD, Inc. Date: Wed, 31 May 2006 19:40:02 -0400 Message-Id: <1149118802.21971.6.camel@shumai.marcuscom.com> Mime-Version: 1.0 X-Mailer: Evolution 2.6.2 FreeBSD GNOME Team Port Cc: current@FreeBSD.org Subject: Re: -CURRENT does not recognize standard mount options X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 May 2006 23:40:33 -0000 --=-+drc+/V6v6nzgn89KlER Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Wed, 2006-05-31 at 11:44 -0400, Craig Rodrigues wrote: > On Tue, May 30, 2006 at 12:30:07PM -0400, Joe Marcus Clarke wrote: > > Should its kernel backend not support all of those options as well? Or > > perhaps global_opts in vfs_mount.c should be updated to support all >=20 > Can you try this patch? I'm not sure if "force" and "sync" > should be global_opts or not because I don't know > if they make sense for every FS, but for symmetry with what was > in mount_msdosfs before, we can push them into the filesystem code for ms= dosfs. > These inconsistencies between the various mount programs and > the various filesystem code is why I've been trying to push > towards using a single mount binary, and pushing the mount option > parsing into vfs_mount.c and the code for the specific filesystem. > We are not quite there yet, but we are a lot closer. This patch fixes the mount problem with sync, but we're left with the other std mount options (such as [no]atime) not working. But I get your point regarding options. I think the moral is I should eliminate noatime, sync, and nosymfollow from the list of common mount options for HAL to use. >=20 >=20 > > MNT_STDOPTS options since mntopts.h says that these are options all > > mounts can understand? Thanks for the follow up. >=20 > The problem is that comments like that were written with a UFS-centric > view. It may not necessarily be true that the various filesystems > support all the "STD" mount options. However, if you see > something that you think should work, let me know and we can > add it to global_opts if it is obvious that it should work for all filesy= stems, > or to the option code for a specific filesystem like msdosfs if the > mount option only works on specific filesystems. Understood, thanks. Joe --=20 Joe Marcus Clarke FreeBSD GNOME Team :: gnome@FreeBSD.org FreeNode / #freebsd-gnome http://www.FreeBSD.org/gnome --=-+drc+/V6v6nzgn89KlER Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.3 (FreeBSD) iD8DBQBEfilSb2iPiv4Uz4cRAs8SAJ4ixRZXoetDNs0rPCQ6IGT3O56gDgCdHLMH l3Jbsoni6R5/+2piSQwmkaE= =RHMq -----END PGP SIGNATURE----- --=-+drc+/V6v6nzgn89KlER--