Date: Wed, 24 Mar 2010 16:20:20 -0400 From: John Baldwin <jhb@freebsd.org> To: "Bjoern A. Zeeb" <bz@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r205626 - head/sys/kern Message-ID: <201003241620.20516.jhb@freebsd.org> In-Reply-To: <201003241921.o2OJLQTC090739@svn.freebsd.org> References: <201003241921.o2OJLQTC090739@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wednesday 24 March 2010 3:21:26 pm Bjoern A. Zeeb wrote: > Author: bz > Date: Wed Mar 24 19:21:26 2010 > New Revision: 205626 > URL: http://svn.freebsd.org/changeset/base/205626 > > Log: > Print the pointer to the lock with the panic message. The previous > panic: rw lock not unlocked > was not really helpful for debugging. Now one can at least call > show lock <ptr> > form ddb to learn more about the lock. Hmm, for consistency you may wish to fix similar panic messages in sx_destroy() and mtx_destroy(). There are many, many other panic messages in mtx, sx, and rwlock that do not include the lock pointer (though many do include the file/line which is nearly as useful). -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201003241620.20516.jhb>