Date: Tue, 1 Aug 2006 09:40:16 +0900 From: Pyun YongHyeon <pyunyh@gmail.com> To: Gleb Smirnoff <glebius@FreeBSD.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, Robert Watson <rwatson@FreeBSD.org>, cvs-all@FreeBSD.org, Pyun YongHyeon <yongari@FreeBSD.org> Subject: Re: cvs commit: src/sys/dev/em if_em.c Message-ID: <20060801004016.GB39581@cdnetworks.co.kr> In-Reply-To: <20060731194311.GV96644@FreeBSD.org> References: <200607200357.k6K3vwg2039627@repoman.freebsd.org> <20060731131502.GS96644@FreeBSD.org> <20060731144841.Y71432@fledge.watson.org> <20060731194311.GV96644@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Jul 31, 2006 at 11:43:11PM +0400, Gleb Smirnoff wrote: > On Mon, Jul 31, 2006 at 02:49:05PM +0100, Robert Watson wrote: > R> On Mon, 31 Jul 2006, Gleb Smirnoff wrote: > R> > R> >On Thu, Jul 20, 2006 at 03:57:58AM +0000, Pyun YongHyeon wrote: > R> >P> yongari 2006-07-20 03:57:58 UTC > R> >P> > R> >P> FreeBSD src repository > R> >P> > R> >P> Modified files: > R> >P> sys/dev/em if_em.c > R> >P> Log: > R> >P> Honor IFF_DRV_OACTIVE in em_start_locked(). > R> > > R> >Isn't it better to shift this change to the em_start(), to avoid double > R> >check of IFF_DRV_RUNNING? Or may be just merge em_start_locked() into the > R> >em_start()? > R> > R> Isn't em_start_locked() called from quite a few different places, including > R> the interrupt handler, etc, where the mutex is already held? > > It is, so the latter idea won't work. However, in all these places > we can know the status of IFF_DRV_OACTIVE before calling the start > routine. > You're right. Feel free to fix it. I have to solve re(4) issues on sparc64 at the moment... -- Regards, Pyun YongHyeon
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060801004016.GB39581>