Date: Sun, 11 Feb 2001 19:34:28 +0100 From: Jeroen Ruigrok/Asmodai <asmodai@wxs.nl> To: "Andrey A. Chernov" <ache@nagual.pp.ru> Cc: Alexey Zelkin <phantom@FreeBSD.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/libc/locale lmessages.c Message-ID: <20010211193428.S406@daemon.ninth-circle.org> In-Reply-To: <20010211204400.A94085@nagual.pp.ru>; from ache@nagual.pp.ru on Sun, Feb 11, 2001 at 08:44:05PM %2B0300 References: <200102111509.f1BF9Vg00411@freefall.freebsd.org> <20010211204400.A94085@nagual.pp.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
-On [20010211 19:00], Andrey A. Chernov (ache@nagual.pp.ru) wrote: >On Sun, Feb 11, 2001 at 07:09:31 -0800, Alexey Zelkin wrote: >> phantom 2001/02/11 07:09:31 PST >> >> Modified files: >> lib/libc/locale lmessages.c >> Log: >> Don't use hardcoded struct size, use offsetof() instead (make size calculations >> dynamic) > >The same as for lnumeric/lmonetary is true here too, i.e. > >if (!ret) I'd rather prefer if (ret == NULL) or likewise constructs. More style(9) compliant and a hell of a lot more readable. -- Jeroen Ruigrok vd Werven/Asmodai asmodai@[wxs.nl|bart.nl|freebsd.org] Documentation nutter/C-rated Coder BSD: Technical excellence at its best D78D D0AD 244D 1D12 C9CA 7152 035C 1138 546A B867 I'm a child of the air, I'm a witch of the wind... To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010211193428.S406>